Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error banner no longer appearing #1094

Closed
cfatt10 opened this issue May 26, 2016 · 6 comments
Closed

Error banner no longer appearing #1094

cfatt10 opened this issue May 26, 2016 · 6 comments

Comments

@cfatt10
Copy link

cfatt10 commented May 26, 2016

It seems that the red banner that used to drop down from the top when the server returned an error (400, 404, 500, etc.) is no longer appearing. I believe this first started happening when I upgraded my build files from v0.2.15 to v0.2.18. I have pulled the most recent commit to master (4faeb7d at the time of writing) and have tried those build files, but the problem is still persisting.

@Phocea
Copy link
Contributor

Phocea commented Jun 7, 2016

I can concur with this we have the following code capturing business message error on deletion and after clicking the "confirm delete button" we do not have the message popping up anymore, even though the server is returning 400 with the expected payload

    editorialChannel.errorMessage(function (response) {
        if ((response.data.technicalMessage !== null) && (response.data.technicalMessage.length > 0)) {
            return 'Global error: ' + response.status + ' (' + response.data.technicalMessage + ')';
        }
        else {
            return 'Global error: ' + response.status + ' (' + response.data.businessMessage + ')';
        }
    });

@Phocea
Copy link
Contributor

Phocea commented Jun 8, 2016

May be related to #1036

@Phocea
Copy link
Contributor

Phocea commented Oct 12, 2016

Fixed by #1197
@jpetitcolas maybe you can close this issue? :)

@jpetitcolas
Copy link
Contributor

@cfatt10: can you recheck and close the issue if #1197 fixed it? :)

@cfatt10
Copy link
Author

cfatt10 commented Oct 12, 2016

@jpetitcolas The error banners are now showing up again, but I have not been paying close enough attention to tell if it was specifically #1197 that fixed it.

@Kmaschta
Copy link
Contributor

Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants