refactor(quality): remove duplicate print_* functions, shared-constants.sh adoption at 89% (t135.8)

.agents/scripts/coderabbit-cli.sh

@@ -45,7 +45,6 @@ readonly CODERABBIT_CLI_INSTALL_URL="https://cli.coderabbit.ai/install.sh"
 readonly CONFIG_DIR="$HOME/.config/coderabbit"
 readonly API_KEY_FILE="$CONFIG_DIR/api_key"
 
-# Print functions
 print_success() {
     local message="$1"
     echo -e "${GREEN}✅ $message${NC}"
@@ -174,18 +173,6 @@ apply_coderabbit_fixes() {
     return 0
 }
 
-print_warning() {
-    local message="$1"
-    echo -e "${YELLOW}⚠️  $message${NC}"
-    return 0
-}
-
-print_error() {
-    local message="$1"
-    echo -e "${RED}❌ $message${NC}"
-    return 0
-}
-
 print_header() {
     local message="$1"
     echo -e "${PURPLE}🤖 $message${NC}"

.agents/scripts/privacy-filter-helper.sh

@@ -92,7 +92,6 @@ readonly -a DEFAULT_PATTERNS=(
     'SG\.[a-zA-Z0-9_-]{22}\.[a-zA-Z0-9_-]{43}'
 )
 
-# Print functions
 print_success() {
     local message="$1"
     echo -e "${GREEN}[PASS]${NC} $message"
@@ -116,8 +115,6 @@ print_error() {
     echo -e "${RED}[FAIL]${NC} $message" >&2
     return 0
 }
-
-
 print_header() {
     local message="$1"
     echo -e "${PURPLE}$message${NC}"

.agents/scripts/quality-fix.sh

@@ -45,8 +45,6 @@ print_info() {
     echo -e "${BLUE}ℹ️  $message${NC}"
     return 0
 }
-
-
 backup_files() {
     print_info "Creating backup of provider files..."
 

.agents/scripts/readme-helper.sh

@@ -18,10 +18,6 @@ _CACHED_SUBAGENTS=""
 _CACHED_SCRIPTS=""
 
 # Color output functions
-print_success() { local msg="$1"; echo -e "\033[32m[SUCCESS]\033[0m $msg"; return 0; }
-print_error() { local msg="$1"; echo -e "\033[31m[ERROR]\033[0m $msg"; return 0; }
-print_warning() { local msg="$1"; echo -e "\033[33m[WARNING]\033[0m $msg"; return 0; }
-print_info() { local msg="$1"; echo -e "\033[34m[INFO]\033[0m $msg"; return 0; }
 
 # Count main agents (*.md files in .agents/ root, excluding AGENTS.md)
 count_main_agents() {

.agents/scripts/sonarcloud-autofix.sh

@@ -19,10 +19,6 @@ readonly PURPLE='\033[0;35m'
 readonly NC='\033[0m'
 
 print_header() { local msg="$1"; echo -e "${PURPLE}$msg${NC}"; return 0; }
-print_info() { local msg="$1"; echo -e "${BLUE}$msg${NC}"; return 0; }
-print_success() { local msg="$1"; echo -e "${GREEN}✅ $msg${NC}"; return 0; }
-print_warning() { local msg="$1"; echo -e "${YELLOW}⚠️  $msg${NC}"; return 0; }
-print_error() { local msg="$1"; echo -e "${RED}❌ $msg${NC}"; return 0; }
 
 # Fix missing return statements (S7682)
 fix_missing_returns() {

.agents/scripts/watercrawl-helper.sh

@@ -64,7 +64,6 @@ readonly NPM_PACKAGE="@watercrawl/nodejs"
 readonly WATERCRAWL_REPO="https://github.com/watercrawl/WaterCrawl.git"
 readonly WATERCRAWL_DIR="$HOME/.aidevops/watercrawl"
 
-# Print functions
 print_success() {
     local message="$1"
     echo -e "${GREEN}[OK] $message${NC}"

.agents/scripts/x-helper.sh

@@ -26,9 +26,6 @@ source "${SCRIPT_DIR}/shared-constants.sh"
 
 readonly FXTWITTER_API="https://api.fxtwitter.com"
 
-print_success() { printf "${GREEN}%s${NC}\n" "$1"; }
-print_warning() { printf "${YELLOW}%s${NC}\n" "$1"; }
-print_error() { printf "${RED}%s${NC}\n" "$1" >&2; }
 
 extract_tweet_path() {
     local url="$1"