Skip to content

refactor(quality): remove duplicate print_* functions, shared-constants.sh adoption at 89% (t135.8)#493

Merged
marcusquinn merged 1 commit intomainfrom
feature/t135.8-shared-constants-adoption
Feb 7, 2026
Merged

refactor(quality): remove duplicate print_* functions, shared-constants.sh adoption at 89% (t135.8)#493
marcusquinn merged 1 commit intomainfrom
feature/t135.8-shared-constants-adoption

Conversation

@marcusquinn
Copy link
Owner

Summary

  • Removed 30 lines of duplicate print_success/error/warning/info function definitions from 7 scripts that already source shared-constants.sh
  • Adoption is now 165/185 (89%), exceeding the 80% target
  • Remaining 20 scripts are legitimate exceptions: standalone entry points (setup.sh, aidevops.sh), templates, tests, archived scripts, and sourced libraries

Testing

  • bash -n syntax check: 7/7 pass
  • Help command smoke test: 7/7 pass

Implements t135.8 from the Codebase Quality Hardening plan.

…that already source shared-constants.sh (t135.8)

Removed 30 lines of duplicate print_success/error/warning/info function
definitions from scripts that already source shared-constants.sh.
Adoption is now 165/185 (89%), with remaining 20 being legitimate
exceptions (standalone entry points, templates, tests, archived scripts).
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 7, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 46 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/t135.8-shared-constants-adoption

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 31 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Sat Feb 7 23:57:23 UTC 2026: Code review monitoring started
Sat Feb 7 23:57:23 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 31

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 31
  • VULNERABILITIES: 0

Generated on: Sat Feb 7 23:57:26 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2026

@marcusquinn marcusquinn merged commit 29d9d0b into main Feb 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant