t3275: fix quality-debt review feedback for milestone-validation-worker.sh#4633
t3275: fix quality-debt review feedback for milestone-validation-worker.sh#4633alex-solovyev wants to merge 1 commit intomainfrom
Conversation
…tion-worker.sh - CRITICAL: reject --max-retries 0 to prevent false PASS with zero checks - CRITICAL: return 0 on dep install failure to avoid early abort before report/fix-task creation - HIGH: remove -maxdepth 1 from ShellCheck find to cover nested .agents/scripts/**/*.sh - MEDIUM: demote lint/type-check failures to record_warning (advisory, not blocking) - MEDIUM: add --json flag for machine-readable orchestrator output (suppresses human logs, emits JSON summary with total_checks, failures_count, warnings_count, failures[], warnings[], exit_code) Closes #3275
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sat Mar 14 05:59:01 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
2 participants
Summary
Addresses all 5 findings from the CodeRabbit review on PR #2519 for
.agents/scripts/milestone-validation-worker.sh.Changes
CRITICAL fixes
--max-retries 0: Updated regex from^[0-9]+$to^[1-9][0-9]*$— zero was accepted and caused the validation loop to be skipped entirely, returning a false PASS with no checks run.return 1toreturn 0incheck_dependenciesso a failedpkg installrecords the failure viarecord_failand continues to report generation and fix-task creation, rather than aborting the script underset -e.HIGH fix
-maxdepth 1from thefindinvocation — now uses-type fto recurse into all subdirectories under.agents/scripts/, matching the project guideline.agents/scripts/**/*.sh.MEDIUM fixes
record_fail→record_warningfor all three linter paths (JS/TSrun lint, TypeScripttsc --noEmit, Pythonruff check). Lint issues are now warnings that appear in the report but do not flipVALIDATION_PASSEDto false.--jsonoutput mode: AddedJSON_OUTPUTflag and--jsonCLI option. When active, all human-readable log functions (log_info,log_error,log_success,log_warn) are suppressed. At the end of the run,generate_json_reportemits a single JSON object to stdout:{"mission_id":"...","milestone":1,"total_checks":5,"failures_count":0,"warnings_count":1,"skipped_count":1,"failures":[],"warnings":[{"message":"..."}],"exit_code":0}Verification
Closes #3275