fix(t3275): address quality-debt review feedback for milestone-validation-worker.sh#4631
Conversation
…tion-worker.sh - CRITICAL: reject --max-retries 0 (was silently skipping all validation) - CRITICAL: dependency install failure now returns 0 to prevent set -e abort before report generation and fix-task creation - HIGH: shellcheck now recurses into .agents/scripts/** (removed -maxdepth 1) - MEDIUM: lint/type-check failures are advisory (record_warning, not record_fail) - MEDIUM: add --json flag for machine-consumable orchestrator output Closes #3275
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sat Mar 14 05:57:59 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
2 participants
Summary
Addresses all 5 findings from the CodeRabbit review on PR #2519 for
.agents/scripts/milestone-validation-worker.sh.Closes #3275
Changes
CRITICAL fixes
Reject
--max-retries 0: Updated regex from^[0-9]+$to^[1-9][0-9]*$so zero is rejected with a clear error. Previously--max-retries 0skipped the validation loop entirely and returned success without running any checks.Dependency install failure no longer aborts early: Changed
return 1toreturn 0incheck_dependenciesafter recording the failure. Underset -e, the previousreturn 1could abort the script before report generation, mission status update, and fix-task creation ran.HIGH fix
-maxdepth 1from thefindinvocation so all.agents/scripts/**/*.shfiles are linted, not just top-level scripts.MEDIUM fixes
Lint/type-check is now advisory: Changed
record_fail→record_warningfor JS linter, TypeScript type check, and Python ruff. These checks no longer flip the milestone to failed — they produce warnings only, consistent with documented behaviour.--jsonflag for machine-consumable output: AddedJSON_OUTPUTconfig var,--jsonCLI flag, andgenerate_json_reportfunction. When--jsonis set, human-readable logs are redirected to stderr and a single JSON object is emitted to stdout with:mission_id,milestone,total_checks,passed_count,failed_count,skipped_count,warnings_count,passed,failures[],warnings[],exit_code. Exit status behaviour is unchanged.Verification