t3639: fix remaining PR #1948 review feedback in worktrunk.md and worktree-helper.sh#4512
Conversation
…d and worktree-helper.sh - worktree-helper.sh: add non-fatal warning to localdev_auto_branch_rm on helper failure, matching the observability parity of localdev_auto_branch - worktrunk.md: fix example URL scheme from https:// to http:// with note that https:// requires mkcert/local CA configuration - worktrunk.md: add pre-remove hook snippet so Worktrunk users get route cleanup on wt remove (previously only post-create was documented, leaving stale routes when using wt without worktree-helper.sh) - worktrunk.md: clarify that auto-removal only applies when using worktree-helper.sh; Worktrunk users need the pre-remove hook Closes #3639
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sat Mar 14 00:14:12 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|



Summary
Addresses the remaining unactioned review feedback from PR #1948 that was tracked as quality-debt in issue #3639.
Changes:
worktree-helper.sh:localdev_auto_branch_rmnow emits a non-fatal yellow warning on helper failure, matching the observability parity oflocaldev_auto_branch(which already had this). Previously|| truesilently swallowed failures.worktrunk.md: Fixed example URL scheme fromhttps://tohttp://with a note thathttps://requires mkcert/local CA configuration — avoids misleading users who haven't set up TLS locally.worktrunk.md: Addedpre-removehook snippet so Worktrunk users get route cleanup onwt remove. Previously onlypost-createwas documented, leaving stale routes when using Worktrunk withoutworktree-helper.sh.worktrunk.md: Clarified that auto-removal only applies when usingworktree-helper.sh; Worktrunk users need thepre-removehook explicitly.Verification
shellcheck: no new violations (SC1091 info pre-existing, not caused by this change)markdownlint-cli2: 0 errorsCloses #3639