Skip to content

t3639: fix remaining PR #1948 review feedback in worktrunk.md and worktree-helper.sh#4512

Merged
alex-solovyev merged 1 commit intomainfrom
bugfix/t3639-worktrunk-quality-debt
Mar 14, 2026
Merged

t3639: fix remaining PR #1948 review feedback in worktrunk.md and worktree-helper.sh#4512
alex-solovyev merged 1 commit intomainfrom
bugfix/t3639-worktrunk-quality-debt

Conversation

@marcusquinn
Copy link
Owner

Summary

Addresses the remaining unactioned review feedback from PR #1948 that was tracked as quality-debt in issue #3639.

Changes:

  • worktree-helper.sh: localdev_auto_branch_rm now emits a non-fatal yellow warning on helper failure, matching the observability parity of localdev_auto_branch (which already had this). Previously || true silently swallowed failures.

  • worktrunk.md: Fixed example URL scheme from https:// to http:// with a note that https:// requires mkcert/local CA configuration — avoids misleading users who haven't set up TLS locally.

  • worktrunk.md: Added pre-remove hook snippet so Worktrunk users get route cleanup on wt remove. Previously only post-create was documented, leaving stale routes when using Worktrunk without worktree-helper.sh.

  • worktrunk.md: Clarified that auto-removal only applies when using worktree-helper.sh; Worktrunk users need the pre-remove hook explicitly.

Verification

  • shellcheck: no new violations (SC1091 info pre-existing, not caused by this change)
  • markdownlint-cli2: 0 errors

Closes #3639

…d and worktree-helper.sh

- worktree-helper.sh: add non-fatal warning to localdev_auto_branch_rm on
  helper failure, matching the observability parity of localdev_auto_branch
- worktrunk.md: fix example URL scheme from https:// to http:// with note
  that https:// requires mkcert/local CA configuration
- worktrunk.md: add pre-remove hook snippet so Worktrunk users get route
  cleanup on wt remove (previously only post-create was documented, leaving
  stale routes when using wt without worktree-helper.sh)
- worktrunk.md: clarify that auto-removal only applies when using
  worktree-helper.sh; Worktrunk users need the pre-remove hook

Closes #3639
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 14, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • no-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 13be49cd-054d-41cb-8406-bd9dfb7dc66e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/t3639-worktrunk-quality-debt
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the bug Auto-created from TODO.md tag label Mar 14, 2026
@github-actions
Copy link
Contributor

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 414 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Sat Mar 14 00:14:09 UTC 2026: Code review monitoring started
Sat Mar 14 00:14:10 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 414

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 414
  • VULNERABILITIES: 0

Generated on: Sat Mar 14 00:14:12 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link

@alex-solovyev alex-solovyev merged commit 54bd35d into main Mar 14, 2026
19 checks passed
@alex-solovyev alex-solovyev deleted the bugfix/t3639-worktrunk-quality-debt branch March 14, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Auto-created from TODO.md tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quality-debt: .agents/tools/git/worktrunk.md — PR #1948 review feedback (medium)

2 participants