-
Notifications
You must be signed in to change notification settings - Fork 5
refactor: remove oh-my-opencode integration and fix SKILL-SCAN-RESULTS agent #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…S agent Remove oh-my-opencode (OmO) support - not being used, can reference the git clone at ~/Git/oh-my-opencode for future inspiration. - Add SKILL-SCAN-RESULTS.md to SKIP_FILES in agent generator - Remove OmO Sisyphus/Planner-Sisyphus agents from generator - Remove setup_oh_my_opencode() function body (keep stub) - Remove OmO plugin removal from opencode.json migration - Remove OmO section from README.md - Remove 'Oh-My-OpenCode Integration' sections from 8 agent files - Delete .agents/tools/opencode/oh-my-opencode.md - Add deprecated path for cleanup on update - Remove OmO compatibility code from aidevops-plugin.md
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the agent management system by addressing a specific bug and removing an unused integration. The 'SKILL-SCAN-RESULTS.md' file is now correctly excluded from the primary agent list, preventing incorrect behavior in the Tab cycle. Additionally, the entire 'oh-my-opencode' integration has been deprecated and removed, simplifying the codebase and reducing potential overhead, as it was not actively used. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughThis PR comprehensively removes Oh-My-OpenCode integration from the codebase, eliminating documentation sections across agent guides, removing OmO-specific agent injection logic, updating skip file lists, removing configuration schema properties, and simplifying the setup flow by making OmO setup a stub function. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sat Feb 7 02:39:05 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively removes the oh-my-opencode integration, which simplifies the codebase by removing unused features. The changes are comprehensive, covering agent definitions, setup scripts, and documentation across multiple files.
The bug fix to exclude SKILL-SCAN-RESULTS.md from the list of primary agents is also a good correction.
I've found one minor issue in the documentation where a redundant point was introduced during the refactoring. Otherwise, the changes look solid and well-executed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In @.agents/content.md:
- Line 94: Remove the extra trailing blank line at the end of the file so there
is exactly one newline terminator; open .agents/content.md, delete the
additional blank line(s) at EOF and ensure the file ends with a single newline
character.
In @.agents/tools/build-mcp/aidevops-plugin.md:
- Around line 417-418: Remove the duplicated list item by deleting the redundant
line that reads "Plugin hooks become essential (quality gates, etc.)" while
keeping the original "Hooks become essential (quality gates, etc.)" entry;
ensure the surrounding numbered list remains sequentially numbered and
consistent after removal.
In `@setup.sh`:
- Around line 3436-3441: Remove the dead stub function setup_oh_my_opencode and
its surrounding comment block from setup.sh: delete the setup_oh_my_opencode()
definition (including the two comment lines that reference Oh-My-OpenCode being
removed) since there are no callers; ensure no other references to
setup_oh_my_opencode remain in the repo (search for the symbol to confirm) and
run the test/build scripts to verify nothing breaks.
…(t147.7) Addressed 5 valid issues: - Remove trailing blank lines in content.md - Remove duplicate list item in aidevops-plugin.md - Remove dead setup_oh_my_opencode stub (no callers) - Add mkdir -p before touch in add_local_bin_to_path (fish dir) - Add fish config to alias duplicate detection in setup_aliases Already fixed (6 threads): augment return 0, context7 old refs, pointer file count, parse_args return, mutual exclusion guard, non-interactive check_requirements Dismissed (6 threads): Intel Homebrew path (code removed), Bun rc (code removed), lowercase-only y (intentional UX), dir check -e vs -f (unrealistic edge case), shorten warning (intentional verbosity), pr-loop dedup (maintainer dismissed)
…(t147.7) Addressed 5 valid issues: - Remove trailing blank lines in content.md - Remove duplicate list item in aidevops-plugin.md - Remove dead setup_oh_my_opencode stub (no callers) - Add mkdir -p before touch in add_local_bin_to_path (fish dir) - Add fish config to alias duplicate detection in setup_aliases Already fixed (6 threads): augment return 0, context7 old refs, pointer file count, parse_args return, mutual exclusion guard, non-interactive check_requirements Dismissed (6 threads): Intel Homebrew path (code removed), Bun rc (code removed), lowercase-only y (intentional UX), dir check -e vs -f (unrealistic edge case), shorten warning (intentional verbosity), pr-loop dedup (maintainer dismissed)
…(t147.7) (#475) Addressed 5 valid issues: - Remove trailing blank lines in content.md - Remove duplicate list item in aidevops-plugin.md - Remove dead setup_oh_my_opencode stub (no callers) - Add mkdir -p before touch in add_local_bin_to_path (fish dir) - Add fish config to alias duplicate detection in setup_aliases Already fixed (6 threads): augment return 0, context7 old refs, pointer file count, parse_args return, mutual exclusion guard, non-interactive check_requirements Dismissed (6 threads): Intel Homebrew path (code removed), Bun rc (code removed), lowercase-only y (intentional UX), dir check -e vs -f (unrealistic edge case), shorten warning (intentional verbosity), pr-loop dedup (maintainer dismissed)
* fix: triage 17 PR review threads across PRs #418,#413,#412,#399,#394 (t147.7) Addressed 5 valid issues: - Remove trailing blank lines in content.md - Remove duplicate list item in aidevops-plugin.md - Remove dead setup_oh_my_opencode stub (no callers) - Add mkdir -p before touch in add_local_bin_to_path (fish dir) - Add fish config to alias duplicate detection in setup_aliases Already fixed (6 threads): augment return 0, context7 old refs, pointer file count, parse_args return, mutual exclusion guard, non-interactive check_requirements Dismissed (6 threads): Intel Homebrew path (code removed), Bun rc (code removed), lowercase-only y (intentional UX), dir check -e vs -f (unrealistic edge case), shorten warning (intentional verbosity), pr-loop dedup (maintainer dismissed) * chore: mark t147 complete - all 50 review threads resolved across 11 PRs (GH#438)



Summary
Changes
Bug fix:
SKILL-SCAN-RESULTS.mdtoSKIP_FILESingenerate-opencode-agents.shOmO removal (14 files, -828 lines):
setup_oh_my_opencode()in setup.sh.agents/tools/opencode/oh-my-opencode.mdSummary by CodeRabbit
Release Notes