fix: add Oh-My-OpenCode MCPs to LAZY_MCPS for proper disabling#329
fix: add Oh-My-OpenCode MCPs to LAZY_MCPS for proper disabling#329marcusquinn merged 1 commit intomainfrom
Conversation
- Add grep_app, websearch, gh_grep to LAZY_MCPS set - MCP loading policy now correctly disables these - Also disable tool patterns globally (grep_app_*, websearch_*, gh_grep_*) - Previous approach only worked if MCPs existed before policy ran
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where certain Oh-My-OpenCode MCPs were not being properly disabled, leading to incorrect status indications. The changes ensure that these specific MCPs and their related tools are correctly identified and disabled by the system's loading policy, streamlining the use of preferred subagents for GitHub code search and web search functionalities. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Caution Review failedThe pull request is closed. WalkthroughThe PR expands the LAZY_MCPS list to include Oh-My-OpenCode MCPs (grep_app, websearch, gh_grep) and refactors the MCP disabling mechanism from per-MCP logic to a consolidated tool-pattern-based global disable block using pattern matching. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly moves the Oh-My-OpenCode MCPs (grep_app, websearch, gh_grep) to the LAZY_MCPS set to ensure they are properly disabled by the loading policy. The code is also refactored to remove the now-redundant manual MCP disabling logic, simplifying the script. My only suggestion is to make the log message more generic to accurately reflect the replacements for all disabled tools.
| for tool_pattern in omo_tool_patterns: | ||
| if tool_pattern not in config.get('tools', {}): | ||
| config['tools'][tool_pattern] = False | ||
| print(f" Disabled {tool_pattern} tools globally (use @github-search subagent)") |
There was a problem hiding this comment.
The log message suggests using the @github-search subagent as a replacement. While this is correct for grep_app_* and gh_grep_*, it's not accurate for websearch_*, which is for Exa web search. To avoid confusion, I recommend using a more generic message that applies to all disabled tool patterns.
| print(f" Disabled {tool_pattern} tools globally (use @github-search subagent)") | |
| print(f" Disabled {tool_pattern} tools globally (use aidevops subagents instead)") |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Thu Feb 5 02:45:43 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
1 participant
Problem
Oh-My-OpenCode MCPs (
grep_app,websearch) were still showing as 'Connected' afteraidevops update.Root Cause
The previous fix tried to disable MCPs after the loading policy ran, but the MCPs need to be in the
LAZY_MCPSset for the policy to disable them.Fix
Add Oh-My-OpenCode MCPs to
LAZY_MCPS:grep_app- GitHub code search (use@github-searchsubagent instead)websearch- Exa web searchgh_grep- May exist from old configsAlso disable tool patterns globally:
grep_app_*websearch_*gh_grep_*After Update
MCPs should show as 'Disabled' instead of 'Connected'.
Summary by CodeRabbit