-
Notifications
You must be signed in to change notification settings - Fork 5
feat: disable sentry and socket MCPs by default #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are remote MCPs requiring authentication that weren't configured. Move to lazy loading until user sets them up. Only osgrep remains eager-loaded (local, no auth).
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the default loading strategy for Micro-Capability Providers (MCPs) by moving remote, authentication-dependent MCPs ('sentry' and 'socket') from an eager-loaded state to a lazy-loaded one. This adjustment aims to enhance application startup efficiency and reduce initial resource consumption by only initializing these components when they are actively needed. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Caution Review failedThe pull request is closed. WalkthroughRefactors MCP loading strategy by moving 'sentry' and 'socket' from eager to lazy loading, retaining 'osgrep' as exclusively eager. A new policy enforcement loop validates MCP classifications and configures runtime loading behavior. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly disables the sentry and socket MCPs by default by moving them from the eager-loaded list to the lazy-loaded list. This change aligns with the stated goal of disabling remote MCPs that require authentication until they are configured. I have one suggestion to improve the maintainability of the code.
| LAZY_MCPS = {'claude-code-mcp', 'outscraper', 'dataforseo', 'shadcn', 'macos-automator', | ||
| 'gsc', 'localwp', 'chrome-devtools', 'quickfile', 'amazon-order-history', | ||
| 'google-analytics-mcp', 'MCP_DOCKER', 'ahrefs', | ||
| 'playwriter', 'augment-context-engine', 'gh_grep', 'context7'} | ||
| 'playwriter', 'augment-context-engine', 'gh_grep', 'context7', | ||
| 'sentry', 'socket'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and easier maintenance, consider sorting the items in the LAZY_MCPS set alphabetically and placing each item on its own line. This makes it much easier to find specific MCPs and simplifies future modifications.
LAZY_MCPS = {
'ahrefs',
'amazon-order-history',
'augment-context-engine',
'chrome-devtools',
'claude-code-mcp',
'context7',
'dataforseo',
'gh_grep',
'google-analytics-mcp',
'gsc',
'localwp',
'macos-automator',
'MCP_DOCKER',
'outscraper',
'playwriter',
'quickfile',
'sentry',
'shadcn',
'socket',
}
🤖 Augment PR SummarySummary: Moves the auth-required remote MCPs ( 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 'google-analytics-mcp', 'MCP_DOCKER', 'ahrefs', | ||
| 'playwriter', 'augment-context-engine', 'gh_grep', 'context7'} | ||
| 'playwriter', 'augment-context-engine', 'gh_grep', 'context7', | ||
| 'sentry', 'socket'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding sentry/socket to LAZY_MCPS means this script will keep forcing those MCPs to enabled: false on every regeneration if they exist in opencode.json. Is it intentional that they should always remain lazy-loaded (never eager), even after a user finishes auth configuration?
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Remote MCPs requiring auth - disable until configured. Only osgrep remains eager.
Summary by CodeRabbit