Skip to content

GH#2952: Extract session flag paths to script-level constants in pulse-wrapper.sh #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 1 commit into from
Mar 6, 2026
Merged

GH#2952: Extract session flag paths to script-level constants in pulse-wrapper.sh #2978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .agents/scripts/pulse-wrapper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ _sanitize_log_field() {

PIDFILE="${HOME}/.aidevops/logs/pulse.pid"
LOGFILE="${HOME}/.aidevops/logs/pulse.log"
SESSION_FLAG="${HOME}/.aidevops/logs/pulse-session.flag"
STOP_FLAG="${HOME}/.aidevops/logs/pulse-session.stop"
OPENCODE_BIN="${OPENCODE_BIN:-/opt/homebrew/bin/opencode}"
PULSE_DIR="${PULSE_DIR:-${HOME}/Git/aidevops}"
PULSE_MODEL="${PULSE_MODEL:-anthropic/claude-sonnet-4-6}"
Expand Down Expand Up @@ -1151,7 +1153,7 @@ ${state_content}

local kill_reason=""
# Check 0: Stop flag — user ran `aidevops pulse stop` during this cycle (t2943)
if [[ -f "${HOME}/.aidevops/logs/pulse-session.stop" ]]; then
if [[ -f "$STOP_FLAG" ]]; then
kill_reason="Stop flag detected during active pulse — user requested stop"
# Check 1: Wall-clock stale threshold (hard ceiling)
elif [[ "$elapsed" -gt "$PULSE_STALE_THRESHOLD" ]]; then
Expand Down Expand Up @@ -2422,17 +2424,14 @@ _Auto-generated by pulse-wrapper.sh daily quality sweep. The supervisor will rev
# Returns: 0 if pulse should run, 1 if not
#######################################
check_session_gate() {
local session_flag="${HOME}/.aidevops/logs/pulse-session.flag"
local stop_flag="${HOME}/.aidevops/logs/pulse-session.stop"

# Stop flag takes priority — user explicitly paused
if [[ -f "$stop_flag" ]]; then
if [[ -f "$STOP_FLAG" ]]; then
echo "[pulse-wrapper] Pulse paused (stop flag present) — resume with: aidevops pulse start" >>"$LOGFILE"
return 1
fi

# Session start flag — explicit user action, always allowed
if [[ -f "$session_flag" ]]; then
if [[ -f "$SESSION_FLAG" ]]; then
return 0
fi

Expand Down Expand Up @@ -2469,8 +2468,7 @@ main() {

# Re-check stop flag immediately before run_pulse() — a stop may have
# been issued during the prefetch/cleanup phase above (t2943)
local stop_flag_recheck="${HOME}/.aidevops/logs/pulse-session.stop"
if [[ -f "$stop_flag_recheck" ]]; then
if [[ -f "$STOP_FLAG" ]]; then
echo "[pulse-wrapper] Stop flag appeared during setup — aborting before run_pulse()" >>"$LOGFILE"
return 0
fi
Expand Down
Loading