Skip to content

GH#2952: Extract session flag paths to script-level constants in pulse-wrapper.sh#2978

Merged
marcusquinn merged 1 commit intomainfrom
chore/pulse-wrapper-session-flag-constant
Mar 6, 2026
Merged

GH#2952: Extract session flag paths to script-level constants in pulse-wrapper.sh#2978
marcusquinn merged 1 commit intomainfrom
chore/pulse-wrapper-session-flag-constant

Conversation

@marcusquinn
Copy link
Owner

Summary

  • Extract hardcoded ~/.aidevops/logs/pulse-session.flag and pulse-session.stop paths from local variables and inline strings into script-level SESSION_FLAG and STOP_FLAG constants, defined alongside PIDFILE/LOGFILE
  • Consistent with pulse-session-helper.sh which already defines these as readonly constants at lines 28-29
  • All 4 hardcoded references (in check_session_gate(), watchdog loop, and pre-run recheck) now use the constants

Closes #2952

…se-wrapper.sh

Replace hardcoded pulse-session.flag and pulse-session.stop paths with
SESSION_FLAG and STOP_FLAG constants defined alongside PIDFILE/LOGFILE.
Consistent with pulse-session-helper.sh which already defines these as
readonly constants. Improves maintainability if paths ever change.

Closes #2952
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 108 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Fri Mar 6 04:55:24 UTC 2026: Code review monitoring started
Fri Mar 6 04:55:25 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 108

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 108
  • VULNERABILITIES: 0

Generated on: Fri Mar 6 04:55:27 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 37 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e9c1370b-f68b-4155-a571-cb1077d23407

📥 Commits

Reviewing files that changed from the base of the PR and between 3540dc8 and 91b1b2a.

📒 Files selected for processing (1)
  • .agents/scripts/pulse-wrapper.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/pulse-wrapper-session-flag-constant

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

marcusquinn added a commit that referenced this pull request Mar 6, 2026
…ws (#2980)

When bots are rate-limited, they post quota/rate-limit notices instead of
actual code reviews. The gate was counting these as valid reviews (PASS)
because it only checked for comment existence, not content.

Now both the helper script and CI workflow:
- Base64-encode comment bodies to handle multi-line content correctly
- Check each bot comment against known rate-limit patterns
- Only count comments as real reviews if they don't match rate-limit patterns
- Return WAITING (not PASS) when all bot comments are rate-limit notices
- Show rate-limited bots separately in output and CI summary

Tested against PR #2978 (rate-limited → WAITING) and PR #2933 (real review → PASS).
marcusquinn added a commit that referenced this pull request Mar 6, 2026
…ws (#2980) (#2982)

When bots are rate-limited, they post quota/rate-limit notices instead of
actual code reviews. The gate was counting these as valid reviews (PASS)
because it only checked for comment existence, not content.

Now both the helper script and CI workflow:
- Base64-encode comment bodies to handle multi-line content correctly
- Check each bot comment against known rate-limit patterns
- Only count comments as real reviews if they don't match rate-limit patterns
- Return WAITING (not PASS) when all bot comments are rate-limit notices
- Show rate-limited bots separately in output and CI summary

Tested against PR #2978 (rate-limited → WAITING) and PR #2933 (real review → PASS).
@marcusquinn
Copy link
Owner Author

This PR appears orphaned — no active worker process found and no activity for 6+ hours. Flagging for re-dispatch. If work is still in progress, remove the status:orphaned label.

@marcusquinn marcusquinn merged commit 9ed2c77 into main Mar 6, 2026
19 checks passed
@marcusquinn marcusquinn deleted the chore/pulse-wrapper-session-flag-constant branch March 6, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quality-debt: .agents/scripts/pulse-wrapper.sh — PR #2935 review feedback (medium)

1 participant