Skip to content

t2602: Fix issue-sync-helper.sh dirname failure in headless pulse #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcusquinn wants to merge 1 commit into from
Closed

t2602: Fix issue-sync-helper.sh dirname failure in headless pulse #2604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .agents/scripts/issue-sync-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,13 @@

set -euo pipefail

SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit
# Defensive PATH export — ensures coreutils (sed, grep, awk, jq, gh) are available
# in headless/MCP environments where PATH may be minimal.
export PATH="/usr/local/bin:/usr/bin:/bin:${PATH:-}"

# Use pure-bash parameter expansion instead of dirname (which is an external binary
# and may not be in PATH in headless/MCP environments). See issue #2602.
SCRIPT_DIR="$(cd "${BASH_SOURCE[0]%/*}" && pwd)" || exit
source "${SCRIPT_DIR}/shared-constants.sh"
# shellcheck source=issue-sync-lib.sh
source "${SCRIPT_DIR}/issue-sync-lib.sh"
Expand Down
4 changes: 3 additions & 1 deletion .agents/scripts/issue-sync-lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ _ISSUE_SYNC_LIB_LOADED=1
# Source shared-constants.sh to make the library self-contained.
# Resolves SCRIPT_DIR from BASH_SOURCE so it works when sourced from any location.
if [[ -z "${SCRIPT_DIR:-}" ]]; then
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
# Use pure-bash parameter expansion instead of dirname (external binary).
# See issue #2602 — dirname may not be in PATH in headless/MCP environments.
SCRIPT_DIR="$(cd "${BASH_SOURCE[0]%/*}" && pwd)"
fi
source "${SCRIPT_DIR}/shared-constants.sh"

Expand Down