Skip to content

t1043: Align verify ShellCheck with CI and fix Phase 7b reconciliation #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 1 commit into from
Feb 13, 2026
Merged

t1043: Align verify ShellCheck with CI and fix Phase 7b reconciliation #1406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .agents/scripts/supervisor/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2644,7 +2644,11 @@ run_verify_checks() {
;;
shellcheck)
if command -v shellcheck &>/dev/null; then
if shellcheck "$repo/$check_arg" 2>>"$SUPERVISOR_LOG"; then
# t1041: Use -S warning -x to match CI severity threshold.
# CI uses -S error; verify uses -S warning (catches warnings+errors
# but not info/style like SC2016/SC1091 which are pre-existing noise).
# -x follows source directives so sourced files don't cause SC1091.
if shellcheck -S warning -x "$repo/$check_arg" 2>>"$SUPERVISOR_LOG"; then
log_success " PASS: shellcheck $check_arg"
else
log_error " FAIL: shellcheck $check_arg"
Expand Down
8 changes: 5 additions & 3 deletions .agents/scripts/supervisor/todo-sync.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,13 +1038,15 @@ cmd_reconcile_db_todo() {
fi

# --- Gap 2: TODO.md [x] but DB still in non-terminal state ---
# Terminal states: complete, deployed, verified, failed, blocked, cancelled
# Terminal states: complete, deployed, verified, failed, blocked, cancelled, verify_failed
# Non-terminal: queued, dispatched, running, evaluating, retrying,
# pr_review, review_triage, merging, merged, deploying, verifying, verify_failed
# pr_review, review_triage, merging, merged, deploying, verifying
# t1041: verify_failed is excluded — it's a meaningful state (PR merged+deployed
# but post-merge checks failed). Re-verification handles these, not reconciliation.
local all_db_tasks
all_db_tasks=$(db -separator '|' "$SUPERVISOR_DB" "
SELECT t.id, t.status FROM tasks t
WHERE t.status NOT IN ('complete', 'deployed', 'verified', 'failed', 'blocked', 'cancelled')
WHERE t.status NOT IN ('complete', 'deployed', 'verified', 'verify_failed', 'failed', 'blocked', 'cancelled')
$batch_filter
ORDER BY t.id;
")
Expand Down