Skip to content

hotfix: restore t314 timeout values overwritten by concurrent PR merges #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 1 commit into from
Feb 12, 2026
Merged

hotfix: restore t314 timeout values overwritten by concurrent PR merges #1219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .agents/scripts/supervisor-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10508,11 +10508,11 @@ cmd_pulse() {
fi

# Phase 4: Worker health checks - detect dead, hung, and orphaned workers
local worker_timeout_seconds="${SUPERVISOR_WORKER_TIMEOUT:-1800}" # 30 min default
local worker_timeout_seconds="${SUPERVISOR_WORKER_TIMEOUT:-3600}" # 1 hour default (t314: restored after merge overwrite)
# Absolute max runtime: kill workers regardless of log activity.
# Prevents runaway workers (e.g., shellcheck on huge files) from accumulating
# and exhausting system memory. Default 2 hours.
local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-7200}" # 2 hour default
local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-14400}" # 4 hour default (t314: restored after merge overwrite)
Comment on lines 10512 to +10515
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix stale runtime comment (now 4 hours).
The comment still says “Default 2 hours” but the new default is 14400s (4h). Please update the comment to avoid operator confusion.

🔧 Suggested fix 
-# and exhausting system memory. Default 2 hours.
+# and exhausting system memory. Default 4 hours.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Absolute max runtime: kill workers regardless of log activity.
# Prevents runaway workers (e.g., shellcheck on huge files) from accumulating
# and exhausting system memory. Default 2 hours.
local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-7200}" # 2 hour default
local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-14400}" # 4 hour default (t314: restored after merge overwrite)
# Absolute max runtime: kill workers regardless of log activity.
# Prevents runaway workers (e.g., shellcheck on huge files) from accumulating
# and exhausting system memory. Default 4 hours.
local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-14400}" # 4 hour default (t314: restored after merge overwrite)
🤖 Prompt for AI Agents 
In @.agents/scripts/supervisor-helper.sh around lines 10512 - 10515, The inline
comment above the worker_max_runtime_seconds assignment is stale (it reads
"Default 2 hours") while the variable SUPERVISOR_WORKER_MAX_RUNTIME is set to
14400 (4 hours); update that comment to state "Default 4 hours" (or "4 hour
default") so it matches the value and the existing parenthetical note, ensuring
clarity for the assignment to worker_max_runtime_seconds.

Comment on lines 10514 to +10515
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment on line 10514 is now out of date with the new default value. It should be updated to reflect the change from 2 hours to 4 hours to maintain consistency between the code and its documentation.

Suggested change
# and exhausting system memory. Default 2 hours.
local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-7200}" # 2 hour default
local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-14400}" # 4 hour default (t314: restored after merge overwrite)
# and exhausting system memory. Default 4 hours.
local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-14400}" # 4 hour default (t314: restored after merge overwrite)


if [[ -d "$SUPERVISOR_DIR/pids" ]]; then
for pid_file in "$SUPERVISOR_DIR/pids"/*.pid; do
Expand Down
Loading