hotfix: restore t314 timeout values overwritten by concurrent PR merges#1219
hotfix: restore t314 timeout values overwritten by concurrent PR merges#1219marcusquinn merged 1 commit intomainfrom
Conversation
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a regression where previously established worker timeout configurations were reverted due to conflicting merges from concurrently developed branches. The changes reinstate the intended longer timeout durations for supervisor workers, preventing premature termination of long-running tasks and improving system stability. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughThe pull request increases timeout thresholds in the worker health check logic of the supervisor helper script. The per-worker inactivity timeout doubles from 30 minutes to 1 hour, and the absolute maximum runtime limit doubles from 2 hours to 4 hours. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Thu Feb 12 12:22:10 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.agents/scripts/supervisor-helper.sh:
- Around line 10512-10515: The inline comment above the
worker_max_runtime_seconds assignment is stale (it reads "Default 2 hours")
while the variable SUPERVISOR_WORKER_MAX_RUNTIME is set to 14400 (4 hours);
update that comment to state "Default 4 hours" (or "4 hour default") so it
matches the value and the existing parenthetical note, ensuring clarity for the
assignment to worker_max_runtime_seconds.
| # Absolute max runtime: kill workers regardless of log activity. | ||
| # Prevents runaway workers (e.g., shellcheck on huge files) from accumulating | ||
| # and exhausting system memory. Default 2 hours. | ||
| local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-7200}" # 2 hour default | ||
| local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-14400}" # 4 hour default (t314: restored after merge overwrite) |
There was a problem hiding this comment.
Fix stale runtime comment (now 4 hours).
The comment still says “Default 2 hours” but the new default is 14400s (4h). Please update the comment to avoid operator confusion.
🔧 Suggested fix
-# and exhausting system memory. Default 2 hours.
+# and exhausting system memory. Default 4 hours.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Absolute max runtime: kill workers regardless of log activity. | |
| # Prevents runaway workers (e.g., shellcheck on huge files) from accumulating | |
| # and exhausting system memory. Default 2 hours. | |
| local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-7200}" # 2 hour default | |
| local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-14400}" # 4 hour default (t314: restored after merge overwrite) | |
| # Absolute max runtime: kill workers regardless of log activity. | |
| # Prevents runaway workers (e.g., shellcheck on huge files) from accumulating | |
| # and exhausting system memory. Default 4 hours. | |
| local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-14400}" # 4 hour default (t314: restored after merge overwrite) |
🤖 Prompt for AI Agents
In @.agents/scripts/supervisor-helper.sh around lines 10512 - 10515, The inline
comment above the worker_max_runtime_seconds assignment is stale (it reads
"Default 2 hours") while the variable SUPERVISOR_WORKER_MAX_RUNTIME is set to
14400 (4 hours); update that comment to state "Default 4 hours" (or "4 hour
default") so it matches the value and the existing parenthetical note, ensuring
clarity for the assignment to worker_max_runtime_seconds.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| # and exhausting system memory. Default 2 hours. | ||
| local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-7200}" # 2 hour default | ||
| local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-14400}" # 4 hour default (t314: restored after merge overwrite) |
There was a problem hiding this comment.
The comment on line 10514 is now out of date with the new default value. It should be updated to reflect the change from 2 hours to 4 hours to maintain consistency between the code and its documentation.
| # and exhausting system memory. Default 2 hours. | |
| local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-7200}" # 2 hour default | |
| local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-14400}" # 4 hour default (t314: restored after merge overwrite) | |
| # and exhausting system memory. Default 4 hours. | |
| local worker_max_runtime_seconds="${SUPERVISOR_WORKER_MAX_RUNTIME:-14400}" # 4 hour default (t314: restored after merge overwrite) |
1 participant
Summary
SUPERVISOR_WORKER_TIMEOUT: 1800s → 3600s (1h)SUPERVISOR_WORKER_MAX_RUNTIME: 7200s → 14400s (4h)Root Cause
PRs #1216 (t303) and #1218 (t311.2) were branched before #1215 (t314) merged. Their squash-merges overwrote the timeout changes because they touched the same file. t311.2 then failed again at 1825s with the old 1800s timeout.
Ref #1215
Summary by CodeRabbit