Skip to content

fix: remove 2>/dev/null from cmd_add calls in auto-pickup (t279)#1109

Merged
marcusquinn merged 1 commit intomainfrom
bugfix/t279-cmd-add-log-unknown-options
Feb 11, 2026
Merged

fix: remove 2>/dev/null from cmd_add calls in auto-pickup (t279)#1109
marcusquinn merged 1 commit intomainfrom
bugfix/t279-cmd-add-log-unknown-options

Conversation

@marcusquinn
Copy link
Owner

@marcusquinn marcusquinn commented Feb 11, 2026

Summary

  • Remove 2>/dev/null from 3 cmd_add call sites in auto_pickup_tasks() (lines 12782, 12840, 12896)
  • cmd_add() already has proper unknown option logging via log_error "Unknown option: $1" at line 1831
  • The stderr suppression made the --metadata flag bug (PR fix: remove unsupported --metadata flag from auto-decomposition cmd_add #1071) invisible — unknown options were silently swallowed
  • Pattern: never suppress stderr on internal function calls during development

Testing

  • bash -n syntax check: pass
  • shellcheck -S warning: no new warnings (only pre-existing SC2034 unused vars)
  • Change is minimal (3 lines) and only removes stderr redirection

Closes #1090

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling in automated task dispatch operations to ensure errors are properly surfaced during task auto-pickup instead of being silenced, enabling earlier error detection and better visibility of failures in the dispatch pipeline.

cmd_add() already logs unknown options via log_error, but three call
sites in auto_pickup_tasks() suppressed stderr with 2>/dev/null. This
made the --metadata flag bug (PR #1071) invisible. Unknown options,
parse errors, and other diagnostics are now visible in supervisor logs.
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

Walkthrough

This PR removes stderr redirection from multiple cmd_add function calls in the supervisor script's auto-pickup logic, exposing previously silenced errors and making failures visible during the dispatch process.

Changes

Cohort / File(s) Summary
Error Visibility in Auto-Pickup Logic
.agents/scripts/supervisor-helper.sh
Removed 2>/dev/null redirection from three cmd_add() calls across auto-dispatch branches (#auto-dispatch, Dispatch Queue, and plan-based decomposition), exposing add operation failures that were previously suppressed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

Silence broken, errors surface bright ✨
No more shadows hiding in the night
cmd_add speaks its truth at last
Debugging days now in the past 🔍

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: removing stderr suppression from cmd_add calls in auto-pickup logic, directly addressing issue t279.
Linked Issues check ✅ Passed All coding requirements from issue #1090 are met: stderr suppression removed from three cmd_add call sites in auto_pickup_tasks(), exposing error diagnostics and unknown-option logging as intended.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the objective: only removes 2>/dev/null redirections from cmd_add calls in auto-pickup branches; no unrelated modifications introduced.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/t279-cmd-add-log-unknown-options

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 47 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Wed Feb 11 05:20:58 UTC 2026: Code review monitoring started
Wed Feb 11 05:20:58 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 47

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 47
  • VULNERABILITIES: 0

Generated on: Wed Feb 11 05:21:01 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link

@marcusquinn marcusquinn merged commit dd2c304 into main Feb 11, 2026
10 checks passed
@marcusquinn marcusquinn deleted the bugfix/t279-cmd-add-log-unknown-options branch February 11, 2026 05:23
marcusquinn added a commit that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment