fix: remove 2>/dev/null from cmd_add calls in auto-pickup (t279)#1109
fix: remove 2>/dev/null from cmd_add calls in auto-pickup (t279)#1109marcusquinn merged 1 commit intomainfrom
Conversation
cmd_add() already logs unknown options via log_error, but three call sites in auto_pickup_tasks() suppressed stderr with 2>/dev/null. This made the --metadata flag bug (PR #1071) invisible. Unknown options, parse errors, and other diagnostics are now visible in supervisor logs.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
WalkthroughThis PR removes stderr redirection from multiple Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Wed Feb 11 05:21:01 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|



Summary
2>/dev/nullfrom 3cmd_addcall sites inauto_pickup_tasks()(lines 12782, 12840, 12896)cmd_add()already has proper unknown option logging vialog_error "Unknown option: $1"at line 1831--metadataflag bug (PR fix: remove unsupported --metadata flag from auto-decomposition cmd_add #1071) invisible — unknown options were silently swallowedTesting
bash -nsyntax check: passshellcheck -S warning: no new warnings (only pre-existing SC2034 unused vars)Closes #1090
Summary by CodeRabbit