Skip to content

fix: remove unsupported --metadata flag from auto-decomposition cmd_add#1071

Merged
marcusquinn merged 1 commit intomainfrom
bugfix/supervisor-decomposition-metadata
Feb 11, 2026
Merged

fix: remove unsupported --metadata flag from auto-decomposition cmd_add#1071
marcusquinn merged 1 commit intomainfrom
bugfix/supervisor-decomposition-metadata

Conversation

@marcusquinn
Copy link
Owner

Summary

  • cmd_add() does not accept --metadata — it has a *) log_error "Unknown option: $1"; return 1 ;; catch-all
  • The t274 auto-decomposition code passed --metadata "plan_anchor=..." to cmd_add, which silently failed (error suppressed by 2>/dev/null)
  • This prevented all #plan tasks without subtasks (t008, t012) from being added to the supervisor DB for decomposition dispatch
  • Fix: remove --metadata from the cmd_add call — the plan_anchor is already passed directly to dispatch_decomposition_worker() as a function argument

Evidence

  • rg "^cmd_add" supervisor-helper.sh shows line 1810 with no --metadata option
  • Line 1831: *) log_error "Unknown option: $1"; return 1 ;;
  • Supervisor logs show t008/t012 hitting check_task_already_done but never reaching "Auto-picked" log
  • Manual cmd_add t008 --repo $(pwd) succeeds; with --metadata it fails

cmd_add() does not accept --metadata, causing it to return 1 with
'Unknown option: --metadata'. The error was suppressed by 2>/dev/null,
silently preventing #plan tasks (t008, t012) from being added to the
supervisor DB for decomposition. The plan_anchor is already passed
directly to dispatch_decomposition_worker() and doesn't need to be
stored in the DB.
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@marcusquinn marcusquinn merged commit 436f2be into main Feb 11, 2026
5 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 33 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/supervisor-decomposition-metadata

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 46 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Wed Feb 11 03:27:21 UTC 2026: Code review monitoring started
Wed Feb 11 03:27:22 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 46

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 46
  • VULNERABILITIES: 0

Generated on: Wed Feb 11 03:27:24 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link

marcusquinn added a commit that referenced this pull request Feb 11, 2026
cmd_add() already logs unknown options via log_error, but three call
sites in auto_pickup_tasks() suppressed stderr with 2>/dev/null. This
made the --metadata flag bug (PR #1071) invisible. Unknown options,
parse errors, and other diagnostics are now visible in supervisor logs.
marcusquinn added a commit that referenced this pull request Feb 11, 2026
cmd_add() already logs unknown options via log_error, but three call
sites in auto_pickup_tasks() suppressed stderr with 2>/dev/null. This
made the --metadata flag bug (PR #1071) invisible. Unknown options,
parse errors, and other diagnostics are now visible in supervisor logs.
@marcusquinn marcusquinn deleted the bugfix/supervisor-decomposition-metadata branch February 21, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant