This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
Make Box fill in its background #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this tails (and therefore includes) the changes in #82, which are necessary to make it work right. |
|
Regarding the tests, I don't have any complaints over this. I think it's completely reasonable now that the Box isn't just a container but a stylable element. Nice work! |
Update tests to reflect this. Add tests for Box styling that test this, and partial style application within a Box. I think this (and preceding commits) fix marcusolsson#45.
|
Rebased after merge of #82. |
This was referenced Jan 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45.
Makes tests a lot less pretty, since it shows a lot of the places where
emptyChsecretly means "there's aBoxover this that isn't explicitly drawing anything here.I'm sure this has some amount of performance impact, but, see #88.