Background colour for HBox #45
Comments
|
I think this is probably what I would expect to get from setting Huge thanks for letting me know what you'd like to see in tui-go! |
|
Awesome! Thanks for making a termlib that's easily accessible. I'm going to
study the source this week and see if I can help out in some way.
…On 25 Jul. 2017 00:15, "Marcus Olsson" ***@***.***> wrote:
I think this is probably what I would expect to get from setting theme.SetStyle("box",
tui.Style{Fg: tui.ColorBlue, Bg: tui.ColorRed). This should be a fairly
straightforward fix.
Huge thanks for letting me know what you'd like to see in tui-go!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB2pYCFrwfUdcj0y66k-J1ZthErx4-rzks5sRKcDgaJpZM4OhN1O>
.
|
|
I made a fix for this in my local branch, but after looking at the code, wouldn't it be better to have a custom style defined in WidgetBase that each component uses as an override for default styles? |
|
Thanks! Also, super cool that you're interested in contributing to tui-go! Yes, I think you're right about allowing custom styles for all widgets. Right now, the only widget that supports custom styling is the Edit: I created #46 in case we want to continue this discussion. |
Update tests to reflect this. Add tests for Box styling that test this, and partial style application within a Box. I think this (and preceding commits) fix marcusolsson#45.
Update tests to reflect this. Add tests for Box styling that test this, and partial style application within a Box. I think this (and preceding commits) fix marcusolsson#45.
Update tests to reflect this. Add tests for Box styling that test this, and partial style application within a Box. I think this (and preceding commits) fix marcusolsson#45.
Update tests to reflect this. Add tests for Box styling that test this, and partial style application within a Box. I think this (and preceding commits) fix marcusolsson#45.
Update tests to reflect this. Add tests for Box styling that test this, and partial style application within a Box. I think this (and preceding commits) fix marcusolsson#45.
Update tests to reflect this. Add tests for Box styling that test this, and partial style application within a Box. I think this (and preceding commits) fix marcusolsson#45.
Update tests to reflect this. Add tests for Box styling that test this, and partial style application within a Box. I think this (and preceding commits) fix #45.
Is there a way I can set a BG colour for an HBox? I'm making a custom status bar using HBox and spacers and whilst it looks good so far, having a background colour would be awesome!
The text was updated successfully, but these errors were encountered: