Skip to content

Conversation

@sujaypatil96
Copy link
Contributor

@sujaypatil96 sujaypatil96 commented Jun 16, 2025

This PR upgrades the the GitHub Actions workflows in the repo to use the latest versions of various Actions, poetry configuration steps, documentation build and deployment, etc.

Required to address #406

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

If you are proposing a change to the SSSOM metadata model, you must

  • provide a full, working and valid example in examples/
  • provide a link to the related GitHub issue in the see_also field of the linkml model
  • provide a link to a valid example in the see_also field of the linkml model
  • make sure any new slot is annotated with the appropriate added_in annotation
  • run SSSOM-Py test suite against the updated model

[Add a description, mentioning at least relevant #ISSUE and how it was addressed. A bulleted list of all changes performed by the PR is is helpful.]

Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also activated "trusted publishers" in pypi:

image

@sujaypatil96 sujaypatil96 requested a review from matentzn June 30, 2025 23:13
@sujaypatil96
Copy link
Contributor Author

@matentzn this PR is ready for a second round of review.

Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I still have my one comment which I would just like to have answered for my own understanding but I am sure its fine. I will get a second reviewer.

@dalito
Copy link

dalito commented Jul 11, 2025

Adding an environment name in the trusted publishing setup is strongly encouraged (this refers to the screenshot). In the case here it should be pypi-release. The other changes looked fine to me.

Not related to the changes but it is surprising to see continued support for unsupported Python 3.8 and no support for any version newer than 3.10.

@sujaypatil96
Copy link
Contributor Author

sujaypatil96 commented Jul 15, 2025

Adding an environment name in the trusted publishing setup is strongly encouraged.

Yup, we need to make sure that the environment name is set to pypi-release on PyPI.

Not related to the changes but it is surprising to see continued support for unsupported Python 3.8 and no support for any version newer than 3.10.

I did see that too, but I thought we should limit the scope of this PR to just upgrading Actions so that the latest documentation features are working first, and then I can take on another request to upgrade the version of Python.

@matentzn I think this PR is ready.

@matentzn
Copy link
Collaborator

Adding an environment name in the trusted publishing setup is strongly encouraged (this refers to the #462 (review)). In the case here it should be pypi-release. The other changes looked fine to me.

Thank you @dalito I hope this is better:

image

@matentzn matentzn merged commit fd943e2 into master Jul 16, 2025
4 checks passed
@matentzn matentzn deleted the upgrade-github-actions branch July 16, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants