-
Notifications
You must be signed in to change notification settings - Fork 28
Upgrade GitHub Actions workflows #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@matentzn this PR is ready for a second round of review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I still have my one comment which I would just like to have answered for my own understanding but I am sure its fine. I will get a second reviewer.
|
Adding an environment name in the trusted publishing setup is strongly encouraged (this refers to the screenshot). In the case here it should be Not related to the changes but it is surprising to see continued support for unsupported Python 3.8 and no support for any version newer than 3.10. |
Yup, we need to make sure that the environment name is set to
I did see that too, but I thought we should limit the scope of this PR to just upgrading Actions so that the latest documentation features are working first, and then I can take on another request to upgrade the version of Python. @matentzn I think this PR is ready. |
Thank you @dalito I hope this is better:
|


This PR upgrades the the GitHub Actions workflows in the repo to use the latest versions of various Actions, poetry configuration steps, documentation build and deployment, etc.
Required to address #406
docs/have been added/updated if necessarymake testhas been run locallyIf you are proposing a change to the SSSOM metadata model, you must
examples/see_alsofield of the linkml modelsee_alsofield of the linkml modeladded_inannotation[Add a description, mentioning at least relevant #ISSUE and how it was addressed. A bulleted list of all changes performed by the PR is is helpful.]