-
Notifications
You must be signed in to change notification settings - Fork 28
Add mapping_tool_id slot to model #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding mapping_tool_id as an entity reference. Added a note the mapping_tool that mapping_tool_id should be preferred for a stronger level of standardisation
gouttegd
requested changes
Jun 12, 2025
Co-authored-by: Damien Goutte-Gattat <[email protected]>
Co-authored-by: Damien Goutte-Gattat <[email protected]>
gouttegd
previously approved these changes
Jun 12, 2025
nichtich
previously approved these changes
Jun 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nitpicking comments in the issue #449.
|
@nichtich I added you to the SSSOM core team so your reviews can count; For the rest, I will merge this PR as is anytime after Wednesday 25th. |
gouttegd
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #449
docs/have been added/updated if necessarymake testhas been run locallyIf you are proposing a change to the SSSOM metadata model, you must
examples/see_alsofield of the linkml modelsee_alsofield of the linkml modeladded_inannotationThis PR is adding mapping_tool_id as an entity reference to the SSSOM model. I have also included a note that if possible, this slot should be preferred over the less formal
mapping_toolslot.cc @nichtich @gouttegd