Skip to content

Conversation

@matentzn
Copy link
Collaborator

Resolves #449

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

If you are proposing a change to the SSSOM metadata model, you must

  • provide a full, working and valid example in examples/
  • provide a link to the related GitHub issue in the see_also field of the linkml model
  • provide a link to a valid example in the see_also field of the linkml model
  • make sure any new slot is annotated with the appropriate added_in annotation
  • run SSSOM-Py test suite against the updated model

This PR is adding mapping_tool_id as an entity reference to the SSSOM model. I have also included a note that if possible, this slot should be preferred over the less formal mapping_tool slot.

cc @nichtich @gouttegd

matentzn added 4 commits June 12, 2025 08:25
Adding mapping_tool_id as an entity reference. Added a note the mapping_tool that mapping_tool_id should be preferred for a stronger level of standardisation
matentzn and others added 2 commits June 12, 2025 11:24
gouttegd
gouttegd previously approved these changes Jun 12, 2025
nichtich
nichtich previously approved these changes Jun 13, 2025
Copy link
Contributor

@nichtich nichtich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nitpicking comments in the issue #449.

@matentzn
Copy link
Collaborator Author

@nichtich I added you to the SSSOM core team so your reviews can count;

For the rest, I will merge this PR as is anytime after Wednesday 25th.

@matentzn matentzn dismissed stale reviews from nichtich and gouttegd via f741e8c June 16, 2025 14:24
@matentzn matentzn merged commit ff9abb3 into master Jun 16, 2025
4 checks passed
@matentzn matentzn deleted the mapping-tool-id branch June 16, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New metadata element]: mapping_tool_id

4 participants