Skip to content

feat(pg): include ID column info for tables #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nyurik merged 1 commit into from
Jan 5, 2026
Merged

feat(pg): include ID column info for tables #2485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions martin/src/config/file/tiles/postgres/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use std::borrow::Cow;
use std::cmp::Ordering;
use std::collections::{BTreeMap, HashSet};

Expand Down Expand Up @@ -569,17 +570,20 @@ fn warn_on_rename(old_id: &String, new_id: &String, typ: &str) {
}

fn summary(info: &TableInfo) -> String {
let long_relkind = match info.relkind {
Some('v') => "view".to_string(),
Some('m') => "materialized view".to_string(),
Some('r') => "table".to_string(),
// if we get to any of below lines, this is likely a bug
Some(r) => format!("unknown relkind={r}"),
None => "unknown relkind".to_string(),
let relkind: Cow<_> = match info.relkind {
Some('v') => "view".into(),
Some('m') => "materialized view".into(),
Some('r') => "table".into(),
// printing these variants is likely a bug
Some(r) => format!("unknown relkind={r}").into(),
None => "unknown relkind".into(),
};
// TODO: add column_id to the summary if it is set
let id: Cow<_> = info.id_column.as_ref().map_or_else(
|| "no ID column".into(),
|id| format!("ID column {id}").into(),
);
format!(
"{long_relkind} {}.{} with {} column ({}, SRID={})",
"{relkind} {}.{} with {} column ({}, SRID={}), {id}",
info.schema,
info.table,
info.geometry_column,
Expand Down
Loading