feat(pg): support PostgreSQL materialized views by kunalsinghdadhwal · Pull Request #2279 · maplibre/martin

kunalsinghdadhwal · 2025-10-02T17:13:14Z

Fixes #2267

New Features

Materialized views are now included alongside tables and views in listings and metadata, making them discoverable and accessible in the app.
Descriptions and related information now reflect materialized views where applicable.

Tests

Added fixtures and tests to validate materialized view handling (JSON and PBF responses).
Expanded cross-schema tests to cover objects with the same names across different schemas, improving reliability and preventing name-collision issues.

…case

Copilot

Pull Request Overview

This PR adds support for PostgreSQL materialized views in Martin tile server by treating them as discoverable objects alongside regular tables and views. The change enables materialized views to be included in server listings and accessible via the API.

Key Changes:

Modified SQL query to include materialized views (relkind = 'm') in database object discovery
Added test fixtures and validation for materialized view functionality
Expanded test coverage for cross-schema object handling

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
`martin/src/config/file/postgres/resolver/scripts/query_available_tables.sql`	Updated WHERE clause to include materialized views in database object queries
`tests/fixtures/tables/materialized_view.sql`	Added test fixture with materialized view creation and sample data
`tests/test.sh`	Added test cases for materialized view JSON and PBF response validation

for more information, see https://pre-commit.ci

tests/fixtures/tables/materialized_view.sql

CommanderStorm

Two requests:

Please run just bless to bless the tests snapshots.

Below, there is is_view. It is used to give debug information like here:
https://github.com/maplibre/martin/blob/c16ceabed73ff66fe8d55452341fe01b5f64681f/martin/src/config/file/postgres/builder.rs#L500C4-L500C11

Let's change this to relkind and give more accurate error messages in the usages.

kunalsinghdadhwal · 2025-10-06T11:58:14Z

Two requests:

Please run just bless to bless the tests snapshots.

Below, there is is_view. It is used to give debug information like here: https://github.com/maplibre/martin/blob/c16ceabed73ff66fe8d55452341fe01b5f64681f/martin/src/config/file/postgres/builder.rs#L500C4-L500C11

Let's change this to relkind and give more accurate error messages in the usages.

I have run just bless and for the is_view

do you want me to change it to an Option<String> because currently it is Option<bool> in the struct

config_table.rs@L37

CommanderStorm · 2025-10-06T12:03:04Z

Yes
That, or Option<char> as it only will ever have one char.
If chars are not supported, String is also fine 😉

kunalsinghdadhwal · 2025-10-08T09:55:29Z

I have added the Option<char> but it breaks the code.

Some trait bounds are not satisfied

tests/fixtures/tables/materialized_view.sql

for more information, see https://pre-commit.ci

CommanderStorm

I have added the Option but it breaks the code.
Some trait bounds are not satisfied

I changed this to i8 as Char gets translated this way.

I have not investigated all testcase fails, the code might not be entirely sound.

martin/src/config/file/tiles/postgres/resolver/scripts/query_available_tables.sql

martin/src/config/file/tiles/postgres/builder.rs

…vailable_tables.sql

Signed-off-by: Kunal Singh Dadhwal <kunalsinghdadhwal@gmail.com>

kunalsinghdadhwal · 2025-10-24T07:51:06Z

Kindly review @CommanderStorm

nyurik

great work! one minor thing, and i think ok to merge, but I will let @CommanderStorm drive this. Thanks!

tests/fixtures/tables/materialized_view.sql

tests/test.sh

for more information, see https://pre-commit.ci

fixed

CommanderStorm · 2026-01-05T11:00:35Z

great work! one minor thing, and i think ok to merge, but I will let @CommanderStorm drive this. Thanks!

I seem to have missed this, sorry

## 🤖 New release * `martin-tile-utils`: 0.6.8 -> 0.6.9 (✓ API compatible changes) * `mbtiles`: 0.15.0 -> 0.15.1 (✓ API compatible changes) * `martin-core`: 0.2.5 -> 0.2.6 (✓ API compatible changes) * `martin`: 1.2.0 -> 1.3.0 <details><summary>Changelog</summary> ## `mbtiles` <blockquote> ## [0.15.1](mbtiles-v0.15.0...mbtiles-v0.15.1) - 2026-01-27 ### Added - add MLT decoding support ([#2512](#2512)) - migrate our log library to tracing ([#2494](#2494)) ### Other - unignore `diff_and_patch_bsdiff` test with unique SQLite database names ([#2480](#2480)) - *(mbtiles)* remove the prefix-ism around how files are named for binary diff copy and simpify their naming ([#2478](#2478)) - *(mbtiles)* add assertion messages what we are checking to the copy tests ([#2477](#2477)) </blockquote> ## `martin-core` <blockquote> ## [0.2.6](martin-core-v0.2.5...martin-core-v0.2.6) - 2026-01-27 ### Added - migrate our log library to tracing ([#2494](#2494)) - *(martin-core)* Allow glyph ranges more than 0xFFFF ([#2438](#2438)) ### Fixed - *(perf)* Remove FontSources.masks as they were consuming large amounts of memory even when no font sources were set ([#2519](#2519)) - improve error message if no SVG sprite files are present ([#2516](#2516)) ### Other - move our imports to tracing ([#2500](#2500)) - *(deps)* shear our dependencys ([#2497](#2497)) </blockquote> ## `martin` <blockquote> ## [1.3.0](martin-v1.2.0...martin-v1.3.0) - 2026-01-27 ### Added - *(srv)* Add `route_prefix` configuration for native subpath support without the need of a reverse proxy override ([#2523](#2523)) - add MLT decoding support ([#2512](#2512)) - migrate our log library to tracing ([#2494](#2494)) - improve martin-cp progress output time estimate ([#2491](#2491)) - *(pg)* include ID column info for tables ([#2485](#2485)) - *(pg)* support PostgreSQL materialized views ([#2279](#2279)) - *(martin-core)* Allow glyph ranges more than 0xFFFF ([#2438](#2438)) ### Fixed - *(ui)* clipboard copy for http://0.0.0.0:3000 and unify implementations ([#2487](#2487)) - the `Copy` icon displaying nicely, next to the text and with enough padding ot all items ([#2483](#2483)) - update copy text to include icon for better visibility ([#2482](#2482)) - *(perf)* Remove FontSources.masks as they were consuming large amounts of memory even when no font sources were set ([#2519](#2519)) - improve error message if no SVG sprite files are present ([#2516](#2516)) ### Other - move our request logging to tracing ([#2508](#2508)) - move our imports to tracing ([#2500](#2500)) - *(deps)* shear our dependencys ([#2497](#2497)) - *(ui)* adjust margin for copy icon in URL component ([#2489](#2489)) - unignore `diff_and_patch_bsdiff` test with unique SQLite database names ([#2480](#2480)) - *(mbtiles)* remove the prefix-ism around how files are named for binary diff copy and simpify their naming ([#2478](#2478)) - *(mbtiles)* add assertion messages what we are checking to the copy tests ([#2477](#2477)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Add support for Postgres materialized views (relkind = 'm') and test …

931b899

…case

Copilot AI review requested due to automatic review settings October 2, 2025 17:13

Copilot AI reviewed Oct 2, 2025

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

5c131da

for more information, see https://pre-commit.ci

nyurik reviewed Oct 2, 2025

View reviewed changes

tests/fixtures/tables/materialized_view.sql Outdated Show resolved Hide resolved

CommanderStorm changed the title ~~Add support for Postgres materialized views (relkind = 'm') and test~~ feat(pg): Add support for Postgres materialized views (relkind = 'm') and test Oct 2, 2025

CommanderStorm previously requested changes Oct 2, 2025

View reviewed changes

CommanderStorm marked this pull request as draft October 6, 2025 03:16

kunalsinghdadhwal and others added 2 commits October 6, 2025 17:35

Merge branch 'main' into fix/materialized-views

5b8b21e

Changed Option<bool> to Option<Char> in TableInfo Struct

4dae341

CommanderStorm reviewed Oct 18, 2025

View reviewed changes

tests/fixtures/tables/materialized_view.sql Outdated Show resolved Hide resolved

CommanderStorm and others added 5 commits October 19, 2025 01:19

Apply suggestion from @CommanderStorm

0bf3dce

Merge branch 'main' into fix/materialized-views

05bb10e

[pre-commit.ci] auto fixes from pre-commit.com hooks

487805c

for more information, see https://pre-commit.ci

change the collum to be named relkind

4f731e0

fix more of the tests

729108e

CommanderStorm force-pushed the fix/materialized-views branch from 72fe68c to 729108e Compare October 19, 2025 00:40

[pre-commit.ci] auto fixes from pre-commit.com hooks

aec861f

for more information, see https://pre-commit.ci

CommanderStorm reviewed Oct 19, 2025

View reviewed changes

martin/src/config/file/tiles/postgres/resolver/scripts/query_available_tables.sql Outdated Show resolved Hide resolved

martin/src/config/file/tiles/postgres/builder.rs Outdated Show resolved Hide resolved

CommanderStorm and others added 3 commits October 19, 2025 02:43

Update martin/src/config/file/tiles/postgres/resolver/scripts/query_a…

3a0a9fb

…vailable_tables.sql

Added 'r' as per suggestion

ce58dca

Signed-off-by: Kunal Singh Dadhwal <kunalsinghdadhwal@gmail.com>

Merge branch 'main' into fix/materialized-views

aaa135d

Refactor materialized view creation for comments

933a68c

nyurik reviewed Oct 24, 2025

View reviewed changes

tests/fixtures/tables/materialized_view.sql Outdated Show resolved Hide resolved

tests/test.sh Outdated Show resolved Hide resolved

pre-commit-ci bot and others added 2 commits October 24, 2025 08:40

[pre-commit.ci] auto fixes from pre-commit.com hooks

f9f381d

for more information, see https://pre-commit.ci

Merge branch 'main' into fix/materialized-views

82fbf10

cleanup tests

aed4f1c

nyurik marked this pull request as ready for review January 5, 2026 10:14

pre-commit-ci bot and others added 2 commits January 5, 2026 10:15

chore(fmt): apply pre-commit formatting fixes

16ca5d8

clippy fixes

e7df470

nyurik requested a review from CommanderStorm January 5, 2026 10:23

nyurik approved these changes Jan 5, 2026

View reviewed changes

nyurik changed the title ~~feat(pg): Add support for Postgres materialized views (relkind = 'm') and test~~ feat(pg): support PostgreSQL materialized views Jan 5, 2026

nyurik enabled auto-merge (squash) January 5, 2026 10:25

nyurik merged commit 7fc3d06 into maplibre:main Jan 5, 2026
38 checks passed

CommanderStorm mentioned this pull request Jan 4, 2026

chore: release #2481

Merged

Uh oh!

Conversation

kunalsinghdadhwal commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Features

Tests

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

CommanderStorm left a comment

Choose a reason for hiding this comment

Uh oh!

kunalsinghdadhwal commented Oct 6, 2025

Uh oh!

CommanderStorm commented Oct 6, 2025

Uh oh!

kunalsinghdadhwal commented Oct 8, 2025

Uh oh!

Uh oh!

CommanderStorm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kunalsinghdadhwal commented Oct 24, 2025

Uh oh!

nyurik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CommanderStorm commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kunalsinghdadhwal commented Oct 2, 2025 •

edited

Loading