Skip to content

Update run-with-docker-compose.md to support styles serving#1837

Merged
CommanderStorm merged 2 commits intomaplibre:mainfrom
Andreal2000:patch-1
May 19, 2025
Merged

Update run-with-docker-compose.md to support styles serving#1837
CommanderStorm merged 2 commits intomaplibre:mainfrom
Andreal2000:patch-1

Conversation

@Andreal2000
Copy link
Copy Markdown
Contributor

I have lost a couple hours this morning trying to serve my styles, after tracing your pull request where you add this features i find out that i was using the wrong version of martin (copied from this file of the docs).

Maybe you could add a conf file validation when the server start, to check if there are some incompatible values.

Copilot AI review requested due to automatic review settings May 19, 2025 13:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the Docker Compose example to use the latest Martin image version for serving styles.

  • Bumps the martin service image tag from v0.13.0 to v0.16.0

Copy link
Copy Markdown
Member

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton and sorry 🥵

@CommanderStorm CommanderStorm enabled auto-merge (squash) May 19, 2025 13:39
@CommanderStorm CommanderStorm merged commit 9d3f296 into maplibre:main May 19, 2025
17 of 18 checks passed
@CommanderStorm
Copy link
Copy Markdown
Member

Maybe you could add a conf file validation when the server start, to check if there are some incompatible values

I thought we had this - apparently this is currently broken and does not send a warning 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants