Fix compile time issue with typescript strict mode

[ArthurMetzger]

Since the release of the new version 1.15.0, I have an error in the declaration of 2 methods with the strict mode of Typescript. The strict mode of TS implies to fill the type of returns.

Launch Checklist

• confirm your changes do not include backports from Mapbox projects (unless with compliant license)
• briefly describe the changes in this PR
• include before/after visuals or gifs if this PR includes visual changes
• write tests for all new functionality
• document any changes to public APIs
• post benchmark scores
• manually test the debug page
• apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
• add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>

[HarelM]

I've seen this too today. Thanks for the fix!

[github-actions]

Bundle size report:

Size Change: 0 B
Total Size Before: 205 kB
Total Size After: 205 kB

Output file	Before	After	Change
maplibre-gl.js	196 kB	196 kB	0 B
maplibre-gl.css	8.87 kB	8.87 kB	0 B

ℹ️ View Details

No major changes

[HarelM]

Can you add a changelog comment? And maybe remove the links and keep only the bug/pr number... (my fault)?

[ArthurMetzger]

Can you add a changelog comment? And maybe remove the links and keep only the bug/pr number... (my fault)?

I just updated the changelog in my PR but don't know how to do the "remove the link and keep the bug/pr number" part.
I'm sorry, can you explain please?

[HarelM]

In line 17 and 18 simply keep the (#issue number) without the [...](...). and add (#194) to the new line you added to link to this PR when in will be available in the release notes.

[ArthurMetzger]

Thank you for these explanations. I have modified the PR.

[HarelM]

Thanks! let me know how urgent this is for you as I would like to pull in some more content before releasing a new version...

[ArthurMetzger]

The sooner the better, it's a blocking issue for every Angular user that uses at least the version 10 or above. I didn't try it with React but i assume the fix is as useful if they use the same strict system. So i bet every user with Angular 10+ projet that uses maplibre must be in pain right now ha ha

[HarelM]

It's not fully blocking as you can disable strict mode or use version 1.14.1.something, but I'll see what I can do. I can relate to your pain. Please ping me in a few days in case I forget.

[plusgut]

Thanks for the fixing it, without it we can't update either.
Disabling strict mode is not an option.

[thomasneirynck]

thx @ArthurMetzger, we were running into this as well (cf elastic/kibana#104505 (comment))

thx @HarelM for the quick follow up :)

[HarelM]

"If you build it they will come...", I mean if you pull-request it I will merge it :-)