[Maps] Replace mapbox-gl import with maplibre-gl#104505
[Maps] Replace mapbox-gl import with maplibre-gl#104505nyurik merged 19 commits intoelastic:masterfrom
Conversation
|
Revealed #104518 |
|
drop in replacement seems to fail. compilation tripping over the https://github.com/elastic/kibana/pull/104505/checks?check_run_id=3001756317 |
|
TS-compilation failures seems to have been introduced by maplibre/maplibre-gl-js#30 , which seems to be a 1.15.0 feature. The new addProtocol/removeProtocol functions are missing return types, which is tripping up Kibana's type-checker. |
|
Upgrading to 1.15.2, which includes the TS-type fix 367a863 |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
with #109082, need to resolve merge conflicts |
|
Pinging @elastic/kibana-gis (Team:Geo) |
|
@elasticmachine merge upstream |
mistic
left a comment
There was a problem hiding this comment.
@thomasneirynck can you try the suggestions I left above?
Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
|
@thomasneirynck for the version of types we were declaring those were deprecated (https://www.npmjs.com/package/@types/maplibre-gl) and also made available on the package itself, so I think we were having a conflict there, thats why I've suggested to stop use the types package and only define a dependency on the npm package which already bundles the types |
|
@elasticmachine merge upstream |
* replace import * fix import * upgrade * Update packages/kbn-mapbox-gl/BUILD.bazel Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com> * Update package.json Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com> * commit yarn lock * yarn lock Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
* replace import * fix import * upgrade * Update packages/kbn-mapbox-gl/BUILD.bazel Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com> * Update package.json Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com> * commit yarn lock * yarn lock Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / X-Pack Reporting API Integration Tests.x-pack/test/reporting_api_integration/reporting_and_security/ilm_migration_apis·ts.Reporting APIs ILM policy migration APIs detects when no migration is neededStandard OutStack TraceKibana Pipeline / general / X-Pack Reporting API Integration Tests.x-pack/test/reporting_api_integration/reporting_and_security/ilm_migration_apis·ts.Reporting APIs ILM policy migration APIs "after each" hook for "detects when no migration is needed"Standard OutStack TraceKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/uptime/rest/telemetry_collectors_fleet·ts.apis uptime uptime REST endpoints with generated data telemetry collectors fleet should receive expected results for fleet managed monitors after calling monitor loggingStandard OutStack Traceand 1 more failures, only showing the first 3. Metrics [docs]Async chunks
Unknown metric groupsmiscellaneous assets size
History
To update your PR or re-run it, just comment with: |
Closes #108742.
Replaces mapbox-gl v1.13.1 with maplibre-gl v1.15.2.