Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to invert Y-axis #3679
base: master
Are you sure you want to change the base?
Add option to invert Y-axis #3679
Changes from 19 commits
da850bc
f045eec
7064dfa
59ab00b
59773db
09a183b
7d8d924
8cd919f
7f1dbec
0284958
e6d5a7a
ca94a39
e904004
c760417
16bb723
d44f600
a40a2b3
fdad7b1
db25d42
32dbfdb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should just call
renderer->mapBoundingRect()
, which is the same thing for fixed-size maps.For infinite maps, it seems to me like in that case the origin should just stay where it is, and the only thing we want to do is to negate the Y value, so it should probably be handled explicitly (also in
InvertYAxisHelper::tileY
).Another issue with this is actually that it is completely meaningless for isometric maps, since it will take the map screen pixel height and subtract the non-projected object position. I'm not sure how we can handle isometric maps properly in the case of "invert Y" actually, we may need to add a
mapPixelBoundingRect
(or justmapPixelHeight
) function to theMapRenderer
, since themapBoundingRect
is essentially amapScreenBoundingRect
function.