-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to invert Y-axis #3679
Open
vinnydiehl
wants to merge
20
commits into
mapeditor:master
Choose a base branch
from
vinnydiehl:invert-y
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
da850bc
Added checkbox to Preferences menu and all the methods needed
AdrianFL f045eec
Added helper class to flip Y axis
AdrianFL 7064dfa
Added functionality of the Y flip to the bottom context numbers
AdrianFL 59ab00b
Added the Y flip functionality to the object menu and object properties
AdrianFL 59773db
Small changes for coding style and other feedback provided
AdrianFL 09a183b
Changed InvertYAxisHelper to use MapRenderer and other coding style fix
AdrianFL 7d8d924
Update src/tiled/abstractobjecttool.cpp
bjorn 8cd919f
Update src/tiled/invertyaxishelper.h
bjorn 7f1dbec
Using MapRenderer to obtain size
AdrianFL 0284958
Some formatting adjustments
bjorn e6d5a7a
Merge branch 'master'
bjorn ca94a39
Removed "Internal" namespace
bjorn e904004
Merge branch 'master' into invert-y
vinnydiehl c760417
Change "Invert Y-Axis" to a map property
vinnydiehl 16bb723
Invert object anchor point when Y-axis is inverted
vinnydiehl d44f600
Invert Y-axis when reading/writing the map
vinnydiehl a40a2b3
Snap lower-left corner to grid when Y is inverted
vinnydiehl fdad7b1
Remove vestigal preferences declaration
vinnydiehl db25d42
Use MapObject::alignment() to invert anchor point
vinnydiehl 32dbfdb
Clean up changes on `invert-y`
vinnydiehl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
/* | ||
* invertyaxishelper.h | ||
* Copyright 2013, Thorbjørn Lindeijer <[email protected]> | ||
* Copyright 2018, Adrian Frances <[email protected]> | ||
* | ||
* This file is part of Tiled. | ||
* | ||
* This program is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License as published by the Free | ||
* Software Foundation; either version 2 of the License, or (at your option) | ||
* any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for | ||
* more details. | ||
* | ||
* You should have received a copy of the GNU General Public License along with | ||
* this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
#pragma once | ||
|
||
#include "mapdocument.h" | ||
#include "maprenderer.h" | ||
#include "preferences.h" | ||
|
||
namespace Tiled { | ||
|
||
class InvertYAxisHelper | ||
{ | ||
public: | ||
InvertYAxisHelper(MapDocument *mapDocument) | ||
: mMapDocument(mapDocument) | ||
{} | ||
|
||
int tileY(int y) const; | ||
qreal pixelY(qreal y) const; | ||
|
||
private: | ||
MapDocument *mMapDocument; | ||
}; | ||
|
||
/** | ||
* Inverts Y coordinate in tiles when applicable. | ||
*/ | ||
inline int InvertYAxisHelper::tileY(int y) const | ||
{ | ||
// Check if Invert Y Axis is set | ||
if (mMapDocument->map()->invertYAxis()) | ||
return mMapDocument->map()->height() - 1 - y; | ||
return y; | ||
} | ||
|
||
/** | ||
* Inverts Y coordinate in pixels when applicable. | ||
*/ | ||
inline qreal InvertYAxisHelper::pixelY(qreal y) const | ||
{ | ||
// Obtain the map document | ||
if (mMapDocument->map()->invertYAxis()) { | ||
const MapRenderer *renderer = mMapDocument->renderer(); | ||
QRect boundingRect = renderer->boundingRect(QRect(QPoint(), mMapDocument->map()->size())); | ||
return boundingRect.height() - y; | ||
} | ||
return y; | ||
} | ||
|
||
} // Namespace Tiled |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should just call
renderer->mapBoundingRect()
, which is the same thing for fixed-size maps.For infinite maps, it seems to me like in that case the origin should just stay where it is, and the only thing we want to do is to negate the Y value, so it should probably be handled explicitly (also in
InvertYAxisHelper::tileY
).Another issue with this is actually that it is completely meaningless for isometric maps, since it will take the map screen pixel height and subtract the non-projected object position. I'm not sure how we can handle isometric maps properly in the case of "invert Y" actually, we may need to add a
mapPixelBoundingRect
(or justmapPixelHeight
) function to theMapRenderer
, since themapBoundingRect
is essentially amapScreenBoundingRect
function.