-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wip/scripting image #2906
Closed
samhocevar
wants to merge
264
commits into
mapeditor:wip/scripting-image
from
samhocevar-forks:wip/scripting-image
Closed
Wip/scripting image #2906
samhocevar
wants to merge
264
commits into
mapeditor:wip/scripting-image
from
samhocevar-forks:wip/scripting-image
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* HTML-escape the file name to avoid unintentional formatting * Fixed the case where a highlighted range covers part of the file name, which was ignored before.
Now tries harder to find sequential matches and does a better job at preferring to find a match in the file name part. Also refactored the code so that the code loop is shared between the scoring function and the function outputting the ranges to highlight.
* The popup flickered when the number of search results caused the popup to become smaller. Avoided by adding a stretch and adjusting the size after restoring the current index. * On macOS, the Enter key was not activating the index, due to different behavior in Qt. Fixed by explicitly handling this case. * When closing with Escape, the popup resized back to its full size right before fading out. This was because the text was getting cleared, causing another search query to run that returned all files. Fixed by not clearing the text input. * Create the LocatorWidget on-demand and let it delete itself on close. * Include the name of the folder in the project in the searched part of the file path.
Added a quick way to open a file in the project
Windows build was not getting deployed due to recent changes regarding the version environment variable.
There is no longer a separate itch build.
Since embedded tilesets have no file name, it would try to show an empty menu, leading to mouse events not being handled until the invisible menu was clicked away.
* Adjust the DPI to the current screen using the QFontMetrics::fontDpi, added in Qt 5.14. * Made separators more visible in dark mode. * Removed the outline around the highlighted menu item.
It's not very discoverable as a context menu action, but with the current Properties view we can't add a direct button. Closes mapeditor#2172
Now on Windows searching with a backslash ("\") also works and the paths are rendered with backslashes.
Also moved tileset editor state from global preferences to session.
It's frequently the cause of failed builds. It appears something went wrong with merging 1515875 to master.
No filter should match everything, not nothing. This broke when I made the 'split' skip empty parts.
QMap will insert these entries on-demand in its operator[].
* Renamed "Unity 3D" to just "Unity" * Removed UniTMX (it's repository is stale since early 2013) * Updated links to "Tiled to Unity" and "Tiled TMX Importer" * Replaced the deprecated Tiled2Unity with SuperTiled2Unity * Moved Orthello Pro down the list. Website is down for me currently * Updated link to Tiled Plugin for RPG Maker MV * Added Tiled To Godot Export * Removed TilemapKit (website gone)
It seems more common among other editors (checked Sublime Text, Atom and Defold). Also tweaked the positioning a little so that it generally appears below the tab bar.
It replaces all tile references to the selected tileset on the current map with references to some other tileset.
This was due to a recent regression, causing this option to be always enabled.
Due to a broken condition the TextFile class always used QFile rather than QSaveFile. Thanks to @geoo89 for catching this! See issue mapeditor#2801.
Thanks @Qiuu for paying attention!
Avoiding a conditional jump when determining the chunk coordinates.
…leset When changing the tileset orientation to Isometric, this would cause the selected tile to not get rendered in the Tile Collision Editor when the "Grid Height" was left at its default of 1. Closes mapeditor#2892
When no tileset format could be found for the selected file, an empty error dialog would pop up. Now it says "Unrecognized tileset format". Also tweaked the behavior when dragging images onto the Tilesets view, when the New Tileset dialog pops up for the given image, the dialog will be set to the "Based on Tileset Image" mode. Because it would be really rare that somebody wants to create an "Collection of Images" with that one image in it.
Requested on Discord, only tested on Linux.
When already in "Snap to Fine Grid" mode, Ctrl+Shift switches to "Snap to Grid". Co-authored-by: Thorbjørn Lindeijer <[email protected]>
Co-authored-by: Thorbjørn Lindeijer <[email protected]>
This was possible now that the difference between these functions is abstracted in the grid-iterating version of this function (which should probably get a new name).
…pos-v2 Made the RenderTileCallback more generic.
The @-surrounded notation for variable replacement broke in Qbs 1.14. Building against a more recent version of Qbs might fix issue mapeditor#2845.
Let's see if this helps with issue mapeditor#2845.
Make sure the zip file that is offered for download has the "Tiled.app" as top-level, instead of the "Contents" directory, which doesn't behave well on macOS.
The @-surrounded notation for variable replacement broke in Qbs 1.14. Building against a more recent version of Qbs might fix issue mapeditor#2845. (cherry picked from commit fea6786)
Let's see if this helps with issue mapeditor#2845. (cherry picked from commit e7bedd1)
Make sure the zip file that is offered for download has the "Tiled.app" as top-level, instead of the "Contents" directory, which doesn't behave well on macOS. (cherry picked from commit 77566fc)
Conflicts: .travis.yml
This may lead to a double-zipped download, but uploading the Tiled.app as a folder leads to problems, like files lacking their executable permissions (see issue mapeditor#2845).
…peditor#2904) Also, ignore vim files.
This was referenced Oct 6, 2020
Thanks for the merge, but I prefer to rebase the stuff I did in #2787. I'll get to that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.