Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using CTRL-SHIFT to toggle snapping to fine grid mode #2895

Merged
merged 4 commits into from
Sep 29, 2020

Conversation

sverx
Copy link
Contributor

@sverx sverx commented Sep 19, 2020

Well I don't really know if CTRL-SHIFT is a good idea but since CTRL was to toggle snapping to grid, I thought to keep the idea the CTRL 'toggles' snapping, and with SHIFT you switch to fine grid.
Hopefully it makes sense.

sverx and others added 4 commits September 19, 2020 15:32
(what was I thinking??? :| )
Previously, holding either Ctrl or Ctrl+Shift while in either "Snap to
Grid" mode or in "Snap to Fine Grid" mode would turn off snapping
entirely. Now only Ctrl turns off snapping entirely, but Ctrl+Shift
toggles between snapping to the grid or to the fine grid.
@bjorn
Copy link
Member

bjorn commented Sep 29, 2020

Thanks for opening a pull request!

I felt like Ctrl+Shift should do something useful as well when you're already in "Snap to Fine Grid" mode, rather than turning off snapping entirely which is already covered by just Ctrl. I've updated the patch so that it toggles between "Snap to Fine Grid" and "Snap to Grid" in this case.

Let me know if you see any problems with this change, if not I think this is ready for merging.

@sverx
Copy link
Contributor Author

sverx commented Sep 29, 2020

I don't see any problem, I actually think it's a good idea and I wish it occurred to me in the first place 🤣

@bjorn bjorn merged commit 10c943f into mapeditor:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants