Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iojs win #148

Merged
merged 5 commits into from
Feb 17, 2015
Merged

Fix iojs win #148

merged 5 commits into from
Feb 17, 2015

Conversation

springmeyer
Copy link
Contributor

Makes adjustments to the tests to be able to pass with io.js + other refactoring that improves coverage and test consistency.

springmeyer pushed a commit that referenced this pull request Feb 17, 2015
@springmeyer springmeyer merged commit 2d72392 into master Feb 17, 2015
@springmeyer springmeyer deleted the fix-iojs-win branch February 17, 2015 22:58
Mithgol added a commit to TryGhost/node-sqlite3 that referenced this pull request Feb 17, 2015
@Mithgol
Copy link
Contributor

Mithgol commented Feb 17, 2015

Somehow the changes made in TryGhost/node-sqlite3@cdd8d45 (they declare 2d72392 as the dependency) cannot prevent the message Module did not self-register on AppVeyor:

I guess something is not as simple as I've thought.

@springmeyer
Copy link
Contributor Author

Those node-pre-gyp fixes only fixed the node-pre-gyp tests - they will have no impact elsewhere. But thanks for trying. So we must have some other problem in node-sqlite3?

@Mithgol
Copy link
Contributor

Mithgol commented Feb 18, 2015

Ah, I've just misunderstood the scope of #148.

If only the tests are fixed, then we should still wait for a fix either in the engine (nodejs/node#751) or in the building tool (nodejs/node-gyp#564); only then the generated modules won't cause that error message.

@springmeyer
Copy link
Contributor Author

Right, or we find a way to call /path/to/iojs directly. But I don't currently have good ideas to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants