Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io.js tests fail on windows #147

Closed
springmeyer opened this issue Feb 17, 2015 · 7 comments
Closed

io.js tests fail on windows #147

springmeyer opened this issue Feb 17, 2015 · 7 comments

Comments

@springmeyer
Copy link
Contributor

With io.js the node-pre-gyp tests that shell out to npm test for each test app fail on windows/appveyor with Module did not self-register.

https://ci.appveyor.com/project/Mapbox/node-pre-gyp/build/1.0.216/job/2psngm8nbqjl9w7g#L373

No idea yet what is going wrong.

@springmeyer
Copy link
Contributor Author

disabled in 3124486 just to keep appveyor green for node.js until this mystery is solved.

@Mithgol
Copy link
Contributor

Mithgol commented Feb 17, 2015

I am almost sure that's nodejs/node#751.

@springmeyer
Copy link
Contributor Author

@Mithgol - thank you - that certainly looks like the problem.

@Mithgol
Copy link
Contributor

Mithgol commented Feb 17, 2015

On nodejs/node#751 they're going to fix this problem on the engine's level, but it can also be fixed on a build tools' level — nodejs/node-gyp#564.

(That's a good thing unless some bystander effect happens.)

@springmeyer
Copy link
Contributor Author

Okay. But I'm thinking this is not a major problem overall. I think this is only an issue for how the node-pre-gyp tests work and I can adapt (working on this now). The critical lib/testbinary.js test I think is working for io.js because it actually uses process.execPath will brings in the right binary name.

$ node -e "console.log(process.execPath)"
/Users/dane/.nvm/versions/io.js/v1.2.0/bin/iojs

So, to recap: this should not prevent node-pre-gyp working for users of io.js at all. Right?

@Mithgol
Copy link
Contributor

Mithgol commented Feb 17, 2015

Right.

(Starting from nodejs/node-gyp#564 (comment) some comments seem to imply that process.execPath might become less reliable in the future. However, that's merely a distant possibility.)

@springmeyer
Copy link
Contributor Author

fixed in #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants