Speculative route-start course quick-fix #1869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akitchen
reviewed
Dec 1, 2018
1ec5
approved these changes
Dec 1, 2018
Contributor
There was a problem hiding this comment.
The reasoning behind this fix is that none of the course-related calculations are reliable when first starting on a leg, especially a leg that follows an intermediate waypoint.
Per chat with @JThramer, a more long-term fix is to implement a variation of RouteLegProgress.nearbyCoordinates that includes nearby coordinates on nearby legs. But we want to try out this more tightly scoped change first.
Can you add a changelog entry to this effect?
- Speculatively fixed spurious rerouting when passing an intermediate waypoint. (#1869)
added 3 commits
November 30, 2018 20:01
… a rare situation can occur where the RouteController interpolates user-course incorrectly, causing it to think that an off-route event has occured.
akitchen
force-pushed
the
jerrad/spec-heading-fix
branch
from
9f7ef5b to
2cb5c69
Compare
Contributor
|
Rebased with master / fixed up CHANGELOG.md organization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @mapbox/navigation-ios