Skip to content

Puck Gymnastics #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Guardiola31337 merged 3 commits into from
Sep 29, 2018
Merged

Puck Gymnastics #1354

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
badf04f
use nav native 3.1.1 to do small forward projection to counter act lo…
kevinkreiser Sep 29, 2018
c170a76
move lag to a constant and use within options
kevinkreiser Sep 29, 2018
b12d6e4
fix some minor details
Sep 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/dependencies.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ext {
mapboxMapSdk : '6.5.0',
mapboxSdkServices : '4.0.0',
mapboxEvents : '3.2.0',
mapboxNavigator : '3.0.1',
mapboxNavigator : '3.1.1',
locationLayerPlugin: '0.8.1',
autoValue : '1.5.4',
autoValueParcel : '0.2.5',
Expand Down
2 changes: 2 additions & 0 deletions ...n/src/main/java/com/mapbox/services/android/navigation/v5/navigation/MapboxNavigator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ synchronized void updateRoute(String routeJson) {
}

synchronized NavigationStatus retrieveStatus(Date date) {
// We ask for a point slightly in the future to account for lag in location services
date.setTime(date.getTime() + 1500);
Copy link
Contributor

@Guardiola31337 Guardiola31337 Sep 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about passing the lag as a parameter of retrieveStatus so it can be custom? And then we can add a new option in MapboxNavigationOptions with its corresponding default values (constant in NavigationConstants).

return navigator.getStatus(date);
}

Expand Down