Puck Gymnastics #1354
Merged
Puck Gymnastics #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation services lag
|
|
||
| synchronized NavigationStatus retrieveStatus(Date date) { | ||
| // We ask for a point slightly in the future to account for lag in location services | ||
| date.setTime(date.getTime() + 1500); |
Contributor
There was a problem hiding this comment.
What about passing the lag as a parameter of retrieveStatus so it can be custom? And then we can add a new option in MapboxNavigationOptions with its corresponding default values (constant in NavigationConstants).
Contributor
|
Other than a couple of formatting nit picks was 💯 You got it! Thanks @kevinkreiser looking forward to test it out! |
Guardiola31337
approved these changes
Sep 29, 2018
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Going ahead and merging here.
Thanks again @kevinkreiser
6 tasks
This was referenced Oct 18, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use nav native 3.1.1 to do small forward prediction to counter-act location services lag. Let me know if we should make a constant for this and indeed where such constants would live!