Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export the "dist" file in npm #4423

Merged
merged 3 commits into from
Mar 14, 2017
Merged

Export the "dist" file in npm #4423

merged 3 commits into from
Mar 14, 2017

Conversation

lucaswoj
Copy link
Contributor

Brought into this repository from #4391

When installing mapbox-gl via npm and importing the library like:

import * as mapboxgl from 'mapbox-gl';

The npm resolver is looking for tha main attribute in package.json to further resolve the correct JavaScript file for import.

fixes #3551

@lucaswoj lucaswoj force-pushed the BernhardRode-patch-1 branch from 8674e9b to 08fb15f Compare March 14, 2017 19:22
@lucaswoj lucaswoj changed the title Bernhard rode patch 1 Export the "dist" file in npm Mar 14, 2017
@lucaswoj lucaswoj force-pushed the BernhardRode-patch-1 branch from 08fb15f to 3f6baf5 Compare March 14, 2017 19:24
@lucaswoj
Copy link
Contributor Author

cc @BernhardRode 😄

@lucaswoj lucaswoj requested review from mourner and jfirebaugh and removed request for mourner and jfirebaugh March 14, 2017 20:06
@lucaswoj lucaswoj merged commit 65336e2 into master Mar 14, 2017
@lucaswoj lucaswoj deleted the BernhardRode-patch-1 branch March 14, 2017 20:07
@lucaswoj lucaswoj mentioned this pull request Mar 16, 2017
Merged
andrewharvey pushed a commit to andrewharvey/mapbox-gl-js that referenced this pull request Mar 17, 2017
@lucaswoj @andrewharvey
Export the "dist" file in npm (mapbox#4423)
60b0048 
* feature: export the correct js file in npm

* Fix linter

* Update bundler quickstart docs
mollymerp added a commit that referenced this pull request Mar 20, 2017
@mollymerp
update bundler quickstart
a399ac8 
to reflect changes in #4423
This was referenced Mar 20, 2017
Closed
Closed
Closed
@andrewharvey andrewharvey mentioned this pull request May 11, 2018
Merged
jdeboer-geoplan added a commit to geoplan/mapbox-gl-js that referenced this pull request Jul 12, 2018
@jdeboer-geoplan
mapbox#4423 Add geoplan specific halo-overdraw functionality onto the…
8f01a0c 
… latest version of mapbox.
ghost pushed a commit to geoplan/mapbox-gl-js that referenced this pull request Feb 8, 2021
Merge pull request #2 from geoplan/reAddHaloOverlay
88f0c78 
mapbox#4423 Add geoplan specific halo-overdraw functionality onto the latest version of mapbox.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the distribution build the main NPM entry point
2 participants
@lucaswoj @BernhardRode