Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run prepublish script on actual npm publish #3493

Merged
merged 1 commit into from
Oct 31, 2016
Merged

Conversation

mourner
Copy link
Member

@mourner mourner commented Oct 31, 2016

Makes prepublish script run only when executed in context of npm publish, addressing previous concerns with #3476. We'll get rid of it after setting up publishing from Circle. @jfirebaugh @lucaswoj

@mourner mourner merged commit 8127e17 into master Oct 31, 2016
@mourner mourner deleted the in-publish branch October 31, 2016 19:13
@andrewharvey
Copy link
Collaborator

cc @jfirebaugh @mourner @lucaswoj

I'm using yarn add https://github.com/mapbox/mapbox-gl-js.git#master in my project to use the master branch, however this PR applied the in-published check in prepublish. That means that when mapbox-gl get's installed automatically when I yarn or npm install my project it doesn't build the mapbox-gl dist files, but the dist files are needed for both the stylesheet and the main defined in the package.json, so the package doesn't work.

Does this still make sense now that the dist files are used as the entry point (done in #4423)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants