Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue a clearer error message when queryRenderedFeatures parameters.layers isn't an Array #4331

Conversation

andrewharvey
Copy link
Collaborator

Launch Checklist

  • briefly describe the changes in this PR

if you call map.queryRenderedFeatures passing parameters.layers as a String such as layer by mistake (it expects an Array of strings) it will issue an error:

The layer 'l' does not exist in the map's style and cannot be queried for features.

This PR adds a different error message to let you know you need to pass an Array.

  • write tests for all new functionality
  • document any changes to public APIs

No changes.

  • post benchmark scores
  • manually test the debug page

Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jfirebaugh jfirebaugh merged commit 28bde4d into mapbox:master Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants