issue an error when queryRenderedFeatures parameters.layers isn't an …

…Array (#4331)
mapbox · Feb 27, 2017 · 28bde4d · 28bde4d
1 parent 78fc9c4
commit 28bde4d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/style/style.js b/src/style/style.js
@@ -742,6 +742,10 @@ class Style extends Evented {
 
         const includedSources = {};
         if (params && params.layers) {
+            if (!Array.isArray(params.layers)) {
+                this.fire('error', {error: 'parameters.layers must be an Array.'});
+                return;
+            }
             for (const layerId of params.layers) {
                 const layer = this._layers[layerId];
                 if (!layer) {

diff --git a/test/unit/style/style.test.js b/test/unit/style/style.test.js
@@ -1216,6 +1216,16 @@ test('Style#queryRenderedFeatures', (t) => {
             t.end();
         });
 
+        t.test('checks type of `layers` option', (t) => {
+            let errors = 0;
+            t.stub(style, 'fire', (type, data) => {
+                if (data.error && data.error.includes('parameters.layers must be an Array.')) errors++;
+            });
+            style.queryRenderedFeatures([{column: 1, row: 1, zoom: 1}], {layers:'string'});
+            t.equals(errors, 1);
+            t.end();
+        });
+
         t.test('includes layout properties', (t) => {
             const results = style.queryRenderedFeatures([{column: 1, row: 1, zoom: 1}], {}, 0, 0);
             const layout = results[0].layer.layout;