Ensure "Tile#loadVectorData" preserves the most recent "rawTileData" #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Sep 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
Tile#rawTileDatais not set tonullafter a "redo placement" operation.fixes #3221
Launch Checklist
Benchmarks
map-load
master 07feb8d: 129 ms
raw-tile-data-3221 9f07ba5: 89 ms
style-load
master 07feb8d: 107 ms
raw-tile-data-3221 9f07ba5: 107 ms
buffer
master 07feb8d: 975 ms
raw-tile-data-3221 9f07ba5: 933 ms
fps
master 07feb8d: 60 fps
raw-tile-data-3221 9f07ba5: 60 fps
frame-duration
master 07feb8d: 6.6 ms, 1% > 16ms
raw-tile-data-3221 9f07ba5: 6.6 ms, 1% > 16ms
query-point
master 07feb8d: 1.07 ms
raw-tile-data-3221 9f07ba5: 1.16 ms
query-box
master 07feb8d: 85.02 ms
raw-tile-data-3221 9f07ba5: 88.38 ms
geojson-setdata-small
master 07feb8d: 14 ms
raw-tile-data-3221 9f07ba5: 13 ms
geojson-setdata-large
master 07feb8d: 144 ms
raw-tile-data-3221 9f07ba5: 134 ms