Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug causing "Map#queryRenderedFeatures" to return no features after "Tile#redoPlacement" #3221

Closed
anandthakker opened this issue Sep 19, 2016 · 0 comments · Fixed by #3233
Closed

Fix bug causing "Map#queryRenderedFeatures" to return no features after "Tile#redoPlacement" #3221

anandthakker opened this issue Sep 19, 2016 · 0 comments · Fixed by #3233
Assignees
@lucaswoj
Labels
bug 🐞 release blocker ⛔
Milestone
Denver

Comments

@anandthakker
Copy link
Contributor

After VectorTileSource#loadTile uses the reload tile method on the worker, tile.rawTileData ends up being set to null. This is happening here: since rawTileData isn't transferred back and forth during reload tile, tile.rawTileData needs to be preserved when performing unloadVectorData.

@lucaswoj I wouldn't expect rawTileData to retain any external references, and so I'd think it should be safe to remove the this.rawTileData = null; from Tile#unloadVectorData. Do you concur?
@lucaswoj lucaswoj changed the title Fix bug causing 'reload tile' to remove vector data needed for feature queries Fix bug causing "Map#queryRenderedFeatures" to return no features after "Tile#redoPlacement" Sep 20, 2016
@lucaswoj lucaswoj self-assigned this Sep 20, 2016
@lucaswoj lucaswoj added this to the Denver milestone Sep 20, 2016
lucaswoj pushed a commit that referenced this issue Sep 20, 2016
Ensure "Tile#loadVectorData" preserves the most recent "rawTileData"
9f07ba5 
fixes #3221
@lucaswoj lucaswoj mentioned this issue Sep 20, 2016
Merged
4 tasks
mourner pushed a commit that referenced this issue Sep 21, 2016
@lucaswoj @mourner
Ensure "Tile#loadVectorData" preserves the most recent "rawTileData" (#…
9574056 
…3233)

fixes #3221
captainbarbosa pushed a commit that referenced this issue Oct 3, 2016
@lucaswoj @captainbarbosa
Ensure "Tile#loadVectorData" preserves the most recent "rawTileData" (#…
d6c51ab 
…3233)

fixes #3221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucaswoj lucaswoj

Labels
bug 🐞 release blocker ⛔
Projects
None yet
Milestone
Denver
Development

Successfully merging a pull request may close this issue.

Ensure "Tile#loadVectorData" preserves the most recent "rawTileData" mapbox/mapbox-gl-js
3 participants
@mourner @lucaswoj @anandthakker