Rework Camera#easeTo to address problems with pitch #3130
Conversation
| </script> | ||
| <div id="centerpoint"><div id="dot"></div></div> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
It makes sense that you built a debug page to use while developing this feature.
Because repository size, simplicity, and stability is important to us, we would prefer not to merge this file into master. Can you please remove this file from the PR?
| endTransform.resize(tr.width, tr.height); | ||
| endTransform.zoom = zoom; | ||
| endTransform.bearing = bearing; | ||
| endTransform.pitch = 0; // fixes #3119 by pretending the map is not pitched; use endTransform.pitch = pitch to revert to the old behavior |
There was a problem hiding this comment.
Let's be mindful of how using Transform in this way affects the architecture of GL JS.
This is a new way to use the Transform class. Transform has all sorts of functionality that isn't being used at this call site. Up until now, we have had exactly one Transform per instance of Camera and the two classes have been tightly coupled together. This change further complicates the role of Transform and its coupling to other modules.
Here is a proposal for a quick refactoring Transform into a few different pieces to enable this use case and improve our overall system architecture:
use an object that implements theCameraOptionsinterface in place ofTransformfactor out all map size state intoCameraorMapfactor out all other functionality inTransforminto separate util functions which takeCameraOptionsas an argument
EDIT: See comment below 👇
Does this make sense?
ref #2801
There was a problem hiding this comment.
Oh! I have another idea that'll require much less work:
- factor
Trasform#pointLocationinto a standalone utility function with the interface
function pointLocation(
point: Point,
viewport: CameraOptions & {width: number, height: number}
)
|
I am closing this PR because it has been inactive for a long time. The branch isn't going anywhere so please keep working on this feature and re-open the PR when it is ready! Let me know if you have any questions. |
Continues on changes in mapbox#3130 pull request
Continues on changes in mapbox#3130 pull request
Description
Fixes #3112 and #3119
Previously, when the map was pitched panning caused unexpected easing and relative adjustments. Pitching the map should not affect easing or the final location of
panBy.This is fixed by calculating the finish state of the map prior to the transition beginning and interpolating from start state to end state accordingly.
One catch: when zooming you don't want to zoom and position to interpolate together since zoom affects the distance between start and end on the screen (so there's an adjustment to take that into account).
Launch Checklist