Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch map.fire to format arguments passed to it. #772

Merged
merged 1 commit into from
May 2, 2018
Merged

Patch map.fire to format arguments passed to it. #772

merged 1 commit into from
May 2, 2018

Conversation

tristen
Copy link
Member

@tristen tristen commented May 1, 2018 •
edited
Loading

Here's another way to do #771 that results in a much smaller PR

Ref #766

@tristen tristen mentioned this pull request May 1, 2018
Closed
@tristen tristen force-pushed the issue-766-monkeypatch branch 5 times, most recently from d9dfeb2 to cf3da55 Compare May 2, 2018 17:00
@mollymerp
Copy link
Contributor

🐒💗

samanpwbb
samanpwbb approved these changes May 2, 2018
View reviewed changes
Copy link
Contributor

@samanpwbb samanpwbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@tristen tristen merged commit bd8193f into master May 2, 2018
@tristen tristen deleted the issue-766-monkeypatch branch May 2, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samanpwbb samanpwbb samanpwbb approved these changes

@mcwhittemore mcwhittemore Awaiting requested review from mcwhittemore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tristen @mollymerp @samanpwbb