Format map.fire call to match breaking change

[tristen]

Taking the easy way out. A complete solution would re-write the draw tools API with its own draw.on('create') using something like EventEmitter.

ref #766

[mcwhittemore]

@tristen - I'd like to have this to not be a breaking change. Is it possible for us to know which version of fire is in mapbox-gl?

[tristen]

@tristen - I'd like to have this to not be a breaking change. Is it possible for us to know which version of fire is in mapbox-gl?

This change still uses fire. It's just that its a private method now and argument signature has changed. The API should remain the same. I think this is close as we can get without dire breaking changes (although it does result in peerDependencies being pinned to [email protected])

[mcwhittemore]

This PR currently requires all users of Draw to update to [email protected] which is the breaking change I'm noting.

[tristen]

OK. I guess we could look at mapboxgl.version and format the argument differently.

[mcwhittemore]

we could do look at mapboxgl.version and format the argument differently.

Cool! This will probably set us up to do the EventEmitter option as well.

[mollymerp]

thanks for taking this on @tristen – let me know if you need anything!

[tristen]

I think this still results in a breaking change. some version field would need to be passed as a required option

new MapboxDraw({
  mapboxglVersion: mapboxgl.version
});

Which we could helpfully throw as an error if the user hasn't passed one.

[tristen]

🚶 #772