Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R] - {0.4.2}: fix sigma MNT-26 #1132

Merged
merged 2 commits into from
Jun 27, 2023
Merged

[R4R] - {0.4.2}: fix sigma MNT-26 #1132

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3456bd2
[fix]: fix sigma MNT-26
Sha3nS Jun 27, 2023
5e54a50
Merge branch 'develop' into bugfix/sigma-MNT-26
Sha3nS Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mt-batcher/services/restorer/handle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@ func (s *DaService) GetDtlBatchTransactionByDataStoreId(c gecho.Context) error {
for i := 0; i < len(newBatchTxn); i++ {
l2Tx := new(types.Transaction)
txDecodeMetaData := new(eigenda.TransactionMeta)
if newBatchTxn[i].TxMeta == nil {
log.Error("Batch tx metadata shouldn't be nil")
continue
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just skip this tx? Perhaps, we might need to return error and wait for developers to check this exception?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't skip this transaction, because the batch submitter always rollup transactions sequentially, and currently it will block on that particular batch, keep retrying and returning an error, a metrics warning will be added here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the error will return out directly

}
err = json.Unmarshal(newBatchTxn[i].TxMeta, txDecodeMetaData)
if err != nil {
log.Error("Unmarshal json fail")
Expand Down