[R4R] - {0.4.2}: fix sigma MNT-26 #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wukongcheng
approved these changes
Jun 27, 2023
abelliumnt
reviewed
Jun 27, 2023
| @@ -148,6 +148,10 @@ func (s *DaService) GetDtlBatchTransactionByDataStoreId(c gecho.Context) error { | |||
| for i := 0; i < len(newBatchTxn); i++ { | |||
| l2Tx := new(types.Transaction) | |||
| txDecodeMetaData := new(eigenda.TransactionMeta) | |||
| if newBatchTxn[i].TxMeta == nil { | |||
| log.Error("Batch tx metadata shouldn't be nil") | |||
| continue | |||
There was a problem hiding this comment.
Can we just skip this tx? Perhaps, we might need to return error and wait for developers to check this exception?
There was a problem hiding this comment.
We can't skip this transaction, because the batch submitter always rollup transactions sequentially, and currently it will block on that particular batch, keep retrying and returning an error, a metrics warning will be added here
There was a problem hiding this comment.
the error will return out directly
abelliumnt
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals of PR
Core changes:
fix sigma audit MNT-26
Notes:
no
Related Issues:
TBD