Remove use of ember-get-config to get the current config #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-cli-notifications ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I'm not too sure about making this change because it would have other effects 🤔 the issue you're having in embroider is due to be fixed in embroider-build/embroider#1412 tho |
|
Curious to know about the side effects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an app with a different configuration between test and development/production. We autoclear the notification on production, but not on tests to test the content of the notification.
Once we switched to embroider, we had some issues when running tests on the /tests route in the browser. The notifications started to disappear.
As the addon use
ember-get-config, it seems of always get the development/production config instead of the test one. So I switched to ember way to do the same.