-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WriteV1Config: fix /tests support #1412
Merged
mansona
merged 5 commits into
embroider-build:main
from
22a:22a/writev1config-testing-support
Jun 7, 2023
Merged
WriteV1Config: fix /tests support #1412
mansona
merged 5 commits into
embroider-build:main
from
22a:22a/writev1config-testing-support
Jun 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22a
commented
May 10, 2023
…#1) * add skeleton scenario with TODO comments * implementing Ed's higher-order test recommendation * fix locationType for tests
22a
force-pushed
the
22a/writev1config-testing-support
branch
from
June 7, 2023 09:08
18aa504
to
d61234f
Compare
mansona
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🎉
achambers
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1387 (development config incorrectly loaded instead of test config when visiting
/tests
withtests: true
,storeConfigInMeta: false
)This PR applies the conditional logic suggested in #1387 (comment)
Example module output with `tests: true`
Example module output with `tests: false`
Answered questions about the implementation for this.
V1Config
with env hardcoded totest
and pass it in?tests: true
andfalse
shows the expected config being loadedsuper([inputTree, undefined])
equivalent tosuper([inputTree])
?scenario
. I'm tracking this work here (Add test scenario fortests: true
storeConfigInMeta: false
config 22a/embroider#1) instead of cluttering this PR with messy attempts to learn the scenario system