Skip to content

terminal: reset style before VT replay of blank cells (on 9961d09be) - #248

Merged
lawrencecchen merged 2 commits into
mainfrom
fix-formatter-blank-cell-style-9961
Sep 30, 2026
Merged

lawrencecchen merged 2 commits into
mainfrom
fix-formatter-blank-cell-style-9961

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Sep 30, 2026 •

Copy link
Copy Markdown

The same two commits as #246, cherry-picked onto 9961d09be, the Ghostty commit cmux main pins today. cmux cannot pin 51c8da0ce yet: on current cmux main, e1b8bf5f4 (the OSC 133;A prompt change from #245) makes cmux DEV.app fail to open its socket in the FuzzRegressions UI test, with or without the formatter fix.

This PR puts e17043471 on fork main so the cmux submodule pin stays reachable. The content already exists on main through #246, so the merge only adds reachability.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes VT replay of blank cells so they no longer inherit the previous cell's background color.

  • Resets the active style before emitting accumulated blank cells, matching the row-break path.
  • Adds a test covering a styled cell followed by skipped default cells.

Written for commit e170434. Summary will update on new commits.

Review in cubic

lawrencecchen and others added 2 commits September 30, 2026 06:20
A styled cell followed by skipped default cells replays the blanks with
the previous cell's background.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The formatter wrote accumulated blank cells as spaces before it switched
to the next cell's style, so the spaces took the previous cell's colors.
Claude Code's mascot sets a black background and skips three cells with
CHA, which a cmux Cloud replay painted as a black box.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@lawrencecchen
lawrencecchen merged commit 572de52 into main Sep 30, 2026
100 of 101 checks passed
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 72c49d29-30fa-4aea-b15b-7240b74c4809

📥 Commits

Reviewing files that changed from the base of the PR and between 64cd5eb and e170434.

📒 Files selected for processing (1)
  • src/terminal/formatter.zig
 _______________________
< R2-D2 is my co-pilot. >
 -----------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant