config: c_get returns window-padding-x/-y (on 9d8d40319)

[lawrencecchen]

ghostty_config_get returned false for window-padding-x and window-padding-y: WindowPadding is a non-packed struct without cval. cmux-next needs the user's value to put its tab icons on the terminal's first text column.

• WindowPadding.C (extern {top_left, bottom_right} u32 points) and cval; ghostty.h declares ghostty_config_window_padding_s.
• window-padding-balance already comes back as its tag name; the test pins it.
• Based on 9d8d40319 (the 9961d09be pin of cmux feat-cmux-next plus the styled-blank-row test fix, without which build-ghosttykit.yml stops before building). Merge with a merge commit so the branch head stays an ancestor of main for the submodule pointer.

Two commits: the failing test c_get: window padding, then the fix. Red/green in cmux build-ghosttykit.yml (new test-filter step): red https://github.com/manaflow-ai/cmux/actions/runs/36783657036, green (also publishes the xcframework) https://github.com/manaflow-ai/cmux/actions/runs/36783660554.

🤖 Generated with Claude Code

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b06d0fae-9fda-443d-aa78-ad3c60e1949c

📥 Commits

Reviewing files that changed from the base of the PR and between 4330ffa and a1026ef.

📒 Files selected for processing (3)

• include/ghostty.h
• src/config/Config.zig
• src/config/c_get.zig

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The public interface now defines a C-compatible type for window padding values. The Zig configuration type converts to this representation, and a test checks padding and balance retrieval.

Changes

Window padding retrieval

Layer / File(s)	Summary
Expose and verify window padding values include/ghostty.h, src/config/Config.zig, src/config/c_get.zig	The public header and Zig configuration type represent padding as top_left and bottom_right unsigned integers. A test checks retrieval of horizontal and vertical padding pairs and the "true" balance value.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: mitchellh

Merge Risk: ⚪ Minimal · up to a1026

The new padding representation and conversion align. The vertical test could be more discriminating, but no current failure is established, so the change appears mergeable.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to a1026

The change exposes two scalar configuration values through an existing read-only API. The C and Zig representations match, and the reviewed path introduces no new privileges, sensitive-data access, or trust-boundary bypass.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The reviewed exposure is limited to native callers retrieving padding from a configuration object they supply. This path does not introduce cross-tenant access, credential authority, or a new remote entrypoint.

Trust Boundaries and Controls

• observed — The getter remains a native C caller boundary: callers supply the configuration, key bytes, and output memory. Unrecognized keys are rejected, but output capacity is not checked; callers must use the documented result type and valid memory. The new padding conversion uses this pre-existing pointer contract rather than adding a separate write mechanism.

Resilience and Maintainability Implications

• inferred — The new conversion is a synchronous scalar copy with no allocation, reservation, persistent mutation, or ownership transfer. It introduces no multi-step transition requiring cleanup or recovery; repeated retrieval replaces the caller's result without changing configuration state.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: c_get now returns window-padding-x and window-padding-y. The commit reference is extra but does not make the title misleading.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}